Fix graphql conflict between role custom object and role dto #10479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds role-related objects and other missing core object names to the reserved keywords list to prevent GraphQL conflicts.
- Added 'role', 'roles', 'userWorkspaceRole', 'userWorkspaceRoles' to
coreObjectNamesinvalidate-object-metadata-input.util.ts - Added singular forms of existing core objects for consistency
- Reorganized the core object names list for better maintainability
- Prevents users from creating custom objects with names that would conflict with system objects
- Resolves potential GraphQL schema conflicts between custom objects and system DTOs
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
prastoin
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Nice thank you so much !
This is a lot of new values
Maybe we should code-generate this list to keep it synched to the reality ? Or maybe we could have a TypeScript linting over existing Standard object names and retrieve a literal we could use to cover all use cases ?
What do you think ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Following the strategy where we want to block custom object creation when the type is reserved by core objects. The issue happened again with the recently introduced role table.