Object conversion functionality #10459

oddieis · 2025-02-24T18:15:59Z

No description provided.

github-actions · 2025-02-24T18:16:54Z

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against f3c4d5d

oddieis

working on object to object conversion functionality - see issue #10422.
Some testing taking place still

oddieis

working on object to object conversion functionality - see issue #10422.
Some testing taking place still

greptile-apps

PR Summary

This PR introduces a comprehensive lead conversion system with templates and field mapping functionality. The implementation spans both frontend and backend, enabling conversion of leads to other object types with customizable templates and field mappings.

Added ConversionTemplateEntity in /packages/twenty-server/src/modules/lead/conversion-templates/conversion-template.entity.ts with field mapping rules, conversion settings, and matching rules
Implemented LeadConversionService in /packages/twenty-server/src/modules/lead/services/lead-conversion.service.ts with transaction management and field mapping logic, though createRelations method needs implementation
Added frontend components in /packages/twenty-front/src/modules/lead/components/ConversionTemplates/ for template management UI with drag-and-drop functionality
Introduced GraphQL operations in /packages/twenty-front/src/modules/lead/graphql/ for template CRUD and lead conversion, but lacks proper type definitions for fieldMappingRules
Added standard object metadata in /packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/ for lead entity configuration, including icons and field IDs

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{20 file(s) reviewed, 32 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-02-24T18:17:55Z

packages/twenty-front/src/modules/lead/components/ConversionTemplates/TemplateList.tsx

+  );
+
+  const handleDragEnd = useCallback(
+    (result: any) => {


style: Replace 'any' with proper type definition from react-beautiful-dnd (DragEndResult)

Suggested change

(result: any) => {

(result: DragEndResult) => {

greptile-apps · 2025-02-24T18:17:55Z

packages/twenty-front/src/modules/lead/components/ConversionTemplates/TemplateList.tsx

+        <Droppable droppableId="templates">
+          {(provided) => (
+            <div {...provided.droppableProps} ref={provided.innerRef}>
+              {data?.conversionTemplates.map((template: any, index: number) => (


style: Replace 'any' with proper interface for template object

greptile-apps · 2025-02-24T18:18:15Z

packages/twenty-front/src/modules/lead/components/ConversionTemplates/LeadConversionButton.tsx

+
+  const selectedTemplate = selectedTemplateId
+    ? templatesData?.availableTemplatesForLead.find(
+        (t: any) => t.id === selectedTemplateId,


style: avoid using 'any' type - define an interface for the template object structure

Suggested change

(t: any) => t.id === selectedTemplateId,

(t: { id: string; name: string; targetObjectType: string; description?: string }) => t.id === selectedTemplateId,

greptile-apps · 2025-02-24T18:18:16Z

packages/twenty-front/src/modules/lead/components/ConversionTemplates/LeadConversionButton.tsx

+      if (data.convertLead.success) {
+        enqueueSnackBar('Lead converted successfully', {
+          variant: 'success',
+        });
+        onConversionSuccess?.(
+          data.convertLead.convertedObjectId,
+          data.convertLead.convertedObjectType,
+        );
+      }


logic: should handle case where data.convertLead exists but success is false - currently modal closes without error message

Suggested change

if (data.convertLead.success) {

enqueueSnackBar('Lead converted successfully', {

variant: 'success',

});

onConversionSuccess?.(

data.convertLead.convertedObjectId,

data.convertLead.convertedObjectType,

);

}

if (data.convertLead.success) {

enqueueSnackBar('Lead converted successfully', {

variant: 'success',

});

onConversionSuccess?.(

data.convertLead.convertedObjectId,

data.convertLead.convertedObjectType,

);

handleCloseModal();

} else {

enqueueSnackBar('Failed to convert lead', { variant: 'error' });

}

greptile-apps · 2025-02-24T18:18:17Z

packages/twenty-front/src/modules/lead/components/ConversionTemplates/LeadConversionButton.tsx

+      <Button
+        variant="secondary"
+        onClick={handleOpenModal}
+        icon={<IconArrowRight />}
+      >
+        Convert
+      </Button>


style: consider disabling button when no templates are available

greptile-apps · 2025-02-24T18:23:34Z

packages/twenty-server/src/modules/lead/services/lead-conversion.service.ts

+  private async createRelations(
+    queryRunner: any,
+    workspaceId: string,
+    lead: LeadWorkspaceEntity,
+    convertedObjectId: string,
+    targetObjectMetadata: any,
+  ) {
+    // Implementation will depend on the specific relations needed
+    // For example, creating task relations, note relations, etc.
+    // This would involve:
+    // 1. Identifying relevant relations from the lead
+    // 2. Creating corresponding relations for the converted object
+    // 3. Updating any reference tables as needed
+  }


logic: createRelations method is incomplete and needs implementation before production use

greptile-apps · 2025-02-24T18:23:34Z

packages/twenty-server/src/modules/lead/services/lead-conversion.service.ts

+          sourceField: leadField.name,
+          targetField: matchingFields[0].name, // Use the first match
+        });


style: Taking first match without considering field compatibility could lead to incorrect mappings

greptile-apps · 2025-02-24T18:24:03Z

packages/twenty-server/src/modules/lead/standard-objects/lead.workspace-entity.ts

+import { WorkspaceIsNotAuditLogged } from 'src/engine/twenty-orm/decorators/workspace-is-not-audit-logged.decorator';
+import { WorkspaceIsNullable } from 'src/engine/twenty-orm/decorators/workspace-is-nullable.decorator';
+import { WorkspaceIsSystem } from 'src/engine/twenty-orm/decorators/workspace-is-system.decorator';
+import { WorkspaceJoinColumn } from 'src/engine/twenty-orm/decorators/workspace-join-column.decorator';


style: WorkspaceJoinColumn is imported but never used in this file

Suggested change

import { WorkspaceJoinColumn } from 'src/engine/twenty-orm/decorators/workspace-join-column.decorator';

greptile-apps · 2025-02-24T18:24:04Z

packages/twenty-server/src/modules/lead/standard-objects/lead.workspace-entity.ts

+  getTsVectorColumnExpressionFromFields,
+} from 'src/engine/workspace-manager/workspace-sync-metadata/utils/get-ts-vector-column-expression.util';
+import { AttachmentWorkspaceEntity } from 'src/modules/attachment/standard-objects/attachment.workspace-entity';
+import { CompanyWorkspaceEntity } from 'src/modules/company/standard-objects/company.workspace-entity';


style: CompanyWorkspaceEntity is imported but never used in this file

Suggested change

import { CompanyWorkspaceEntity } from 'src/modules/company/standard-objects/company.workspace-entity';

greptile-apps · 2025-02-24T18:25:30Z

packages/twenty-server/src/modules/modules.module.ts

    MessagingModule,
+    LeadModule,


style: LeadModule depends on FavoriteModule (via lead.workspace-entity.ts) but is imported before it. Consider moving LeadModule after FavoriteModule to avoid potential initialization issues.

FelixMalfait · 2025-02-24T21:19:55Z

Are you an AI :) ?

Thanks for this. We love contributions, but please work with us before putting too much time into this because we're usually quite opioniated about how we want to build things, so this might end up being closed. Could you please share a screenshot? I couldn't start the project locally on your branch, there were frontend errors.

oddieis · 2025-02-25T06:05:00Z

Nope not an AI - just a CRM nerd. This was my first PR ever! I'm still going through testing on my side so will work out the fixes sure and re submit. If you don't like the changes I can always keep a local copy for myself as I need this function 😅

…

On Mon, 24 Feb 2025, 21:20 Félix Malfait, ***@***.***> wrote: Are you an AI :) ? Thanks for this. We love contributions, but please work with us before putting too much time into this because we're usually quite opioniated about how we want to build things, so this might end up being closed. Could you please share a screenshot? I couldn't start the project locally on your branch, there were frontend errors. — Reply to this email directly, view it on GitHub <#10459 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFKPXTE2WMAXW673KWF2L32ROEJHAVCNFSM6AAAAABXYWBWSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZZGY3TINBQGI> . You are receiving this because you authored the thread.Message ID: ***@***.***> [image: FelixMalfait]*FelixMalfait* left a comment (twentyhq/twenty#10459) <#10459 (comment)> Are you an AI :) ? Thanks for this. We love contributions, but please work with us before putting too much time into this because we're usually quite opioniated about how we want to build things, so this might end up being closed. Could you please share a screenshot? I couldn't start the project locally on your branch, there were frontend errors. — Reply to this email directly, view it on GitHub <#10459 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFKPXTE2WMAXW673KWF2L32ROEJHAVCNFSM6AAAAABXYWBWSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZZGY3TINBQGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Object conversion functionality

b0166cf

oddieis commented Feb 24, 2025

View reviewed changes

greptile-apps bot reviewed Feb 24, 2025

View reviewed changes

object conversion functionality

f3c4d5d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Object conversion functionality #10459

Object conversion functionality #10459

oddieis commented Feb 24, 2025

github-actions bot commented Feb 24, 2025 •

edited

Loading

oddieis left a comment

oddieis left a comment

greptile-apps bot left a comment

greptile-apps bot Feb 24, 2025

greptile-apps bot Feb 24, 2025

greptile-apps bot Feb 24, 2025

greptile-apps bot Feb 24, 2025

greptile-apps bot Feb 24, 2025

greptile-apps bot Feb 24, 2025

greptile-apps bot Feb 24, 2025

greptile-apps bot Feb 24, 2025

greptile-apps bot Feb 24, 2025

greptile-apps bot Feb 24, 2025

FelixMalfait commented Feb 24, 2025

oddieis commented Feb 25, 2025 via email

	(t: any) => t.id === selectedTemplateId,
	(t: { id: string; name: string; targetObjectType: string; description?: string }) => t.id === selectedTemplateId,

Object conversion functionality #10459

Are you sure you want to change the base?

Object conversion functionality #10459

Conversation

oddieis commented Feb 24, 2025

github-actions bot commented Feb 24, 2025 • edited Loading

Welcome!

oddieis left a comment

Choose a reason for hiding this comment

oddieis left a comment

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Feb 24, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 24, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 24, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 24, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 24, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 24, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 24, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 24, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 24, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 24, 2025

Choose a reason for hiding this comment

FelixMalfait commented Feb 24, 2025

oddieis commented Feb 25, 2025 via email

github-actions bot commented Feb 24, 2025 •

edited

Loading