Add default role to workspace #10444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijreilly
reviewed
Feb 24, 2025
| @@ -190,6 +193,20 @@ export class WorkspaceResolver { | |||
| } | |||
| } | |||
|
|
|||
| @ResolveField(() => RoleDTO, { nullable: true }) | |||
| async defaultRole(@Parent() workspace: Workspace): Promise<RoleDTO | null> { | |||
| if (!workspace.defaultRoleId) { | |||
There was a problem hiding this comment.
should we throw if permissions are enabled and defaultRoleId is missing?
| @@ -184,4 +185,9 @@ export class UpdateWorkspaceInput { | |||
| @IsBoolean() | |||
| @IsOptional() | |||
| isPasswordAuthEnabled?: boolean; | |||
|
|
|||
| @Field({ nullable: true }) | |||
There was a problem hiding this comment.
do we plan on updating this during the roll-out, through a command? as this field should not be null
If yes we can add it to our todo list not to forget
| params.workspace.id, | ||
| ); | ||
|
|
||
| if (isPermissionsEnabled && params.workspace.defaultRoleId) { |
There was a problem hiding this comment.
same here, we should always have a defaultRole, and since we have the isPermissionsEnabled gate here maybe we should throw if we have no defaultRoleId?
ijreilly
reviewed
Feb 24, 2025
| jest | ||
| .spyOn(userWorkspaceService, 'addUserToWorkspace') | ||
| .mockResolvedValue({} as User); | ||
| jest.spyOn(userWorkspaceService, 'addUserToWorkspace').mockResolvedValue({ |
There was a problem hiding this comment.
can we somehow check that a new signed up user has the default role?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adding a defaultRole to each workspace, this role will be automatically added when a member joins a workspace via invite link or public link (seeds work differently though).
Took the occasion to refactor a bit the frontend components, splitting them in smaller components for more readability.
Test