Data changes to prepare for workspaceMember page #10439
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR prepares the backend for a dedicated workspace member page by renaming fields and adjusting relationships to avoid conflicts with morph relationships.
- Renamed
workspaceMembertoforWorkspaceMemberin/packages/twenty-server/src/modules/favorite/standard-objects/favorite.workspace-entity.tsto prevent conflicts - Added
positionfield with ID20202020-1810-4591-a93c-d0df97dca843toWORKSPACE_MEMBER_STANDARD_FIELD_IDSin/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids.ts - Added
@WorkspaceIsSystem()decorators to protect fields inWorkspaceMemberWorkspaceEntityfrom unauthorized modifications - Updated all favorite-related hooks and components to use
forWorkspaceMemberIdinstead ofworkspaceMemberIdfor consistency
16 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -82,7 +82,7 @@ export const sortedFavorites = [ | |||
| labelIdentifier: ' ', | |||
| link: '/object/person/3', | |||
| objectNameSingular: 'person', | |||
| workspaceMemberId: '1', | |||
| forWorWorkspaceMemberId: '1', | |||
There was a problem hiding this comment.
syntax: Typo in field name 'forWorWorkspaceMemberId' - should be 'forWorkspaceMemberId'
| forWorWorkspaceMemberId: '1', | |
| forWorkspaceMemberId: '1', |
| @@ -72,7 +72,7 @@ export const FavoriteFolderPickerEffect = ({ | |||
| const checkedFolderIds = favorites | |||
| .filter( | |||
| (favorite) => | |||
| favorite.recordId === targetId && favorite.workspaceMemberId, | |||
| favorite.recordId === targetId && favorite.forWorkspaceMemberId, | |||
| ) | |||
| .map((favorite) => favorite.favoriteFolderId || 'no-folder'); | |||
There was a problem hiding this comment.
style: Consider handling the case where favoriteFolderId is undefined more explicitly rather than defaulting to 'no-folder' string literal
...ty-server/src/modules/workspace-member/standard-objects/workspace-member.workspace-entity.ts
Outdated
Show resolved
Hide resolved
…bjects/workspace-member.workspace-entity.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
works for me !
I wonder if it is something we should take into account in the frame of permissions. it seems to be a good (future) usecase for row-level permissions: a workspace member can only update their own favorite. Very edgy for now and not worth the effort in my opinion but to keep in mind if we introduce other objects with this concept of "row-owner". @Weiko
Workspace Member will get their own record page in the future.
This PR lays backend changes to prepare for this: