Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Overflow issue in delete record popup #10417

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sharathxct
Copy link

#10411
Issue: After right-clicking on deleted record, popup is cut
Solution: Added text-overflow ellipsis

previous behaviour:

image

fix:

image
image

Copy link
Contributor

github-actions bot commented Feb 23, 2025

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against adcc7b4

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes text overflow issues in the delete record popup by implementing proper text truncation with ellipsis in menu items.

  • Added text-overflow: ellipsis and overflow: hidden to StyledMainText in /packages/twenty-ui/src/navigation/menu-item/internals/components/MenuItemLeftContent.tsx to handle long text gracefully
  • Removed redundant text-decoration property from StyledContextualText to clean up styling

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@FelixMalfait
Copy link
Member

Thanks @Sharathxct!

@Bonapara what do you think of the side effects?
Screenshot 2025-02-24 at 08 26 41
Screenshot 2025-02-24 at 08 27 59

@Bonapara
Copy link
Member

Looks good from a design perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants