Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent element dropping below 'New' Button #10412

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SujithThirumalaisamy
Copy link
Contributor

#10197
Issue: Elements were dropped after the "New" button, And placed back to last index after api refresh.
Solution: Moved the "New" button out of the Draggable to prevent the issue.

Previous behaviour: Reference #10197
Current behavious: Screencast.webm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes an issue in the Kanban board where draggable elements could be incorrectly dropped below the "New" button, causing inconsistent behavior after API refresh.

  • Moved StyledNewButtonContainer outside of the draggable area in /packages/twenty-front/src/modules/object-record/record-board/record-board-column/components/RecordBoardColumnCardsContainer.tsx to prevent cards from being dropped after the "New" button
  • Added isDragDisabled={true} to the bottom Draggable wrapper to ensure consistent behavior
  • Ensures cards maintain their intended order within the droppable area by keeping the "New" button as a static element at the bottom

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant