Improve i18n CI #10390
Merged
Improve i18n CI #10390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the i18n CI workflows by improving the translation management process between Twenty and Crowdin, focusing on better error handling and clearer execution flow.
- Added strict compilation check in
/.github/workflows/i18n-pull.yamlthat allows failures before pulling new translations - Improved file permission handling with
chowncommand to fix Docker container file ownership issues - Consolidated git operations in
/.github/workflows/i18n-push.yamlby combining extract and compile change checks - Added pull-requests write permission in both workflows to ensure proper PR creation capabilities
- Enhanced conditional logic for translation pulls based on compilation status or force_pull parameter
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.