Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4/n]: migrate the RESTAPI GET /rest/* to use TwentyORM directly #10372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pacyL2K19
Copy link
Contributor

This PR

🚧 WIP

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR migrates the GET endpoint in the REST API to use TwentyORM directly instead of going through GraphQL, improving performance by removing the intermediate GraphQL layer.

  • Added new RestApiCoreServiceV2 in /packages/twenty-server/src/engine/api/rest/core/rest-api-core-v2.service.ts to handle direct TwentyORM operations
  • Implemented filter processing system in getWhereFilter method but currently commented out in the GET implementation
  • Added FilterInputFactory to RestApiModule for handling query filter parameters
  • Switched GET endpoint in RestApiCoreController to use restApiCoreServiceV2.get() with RestApiExceptionFilter
  • Commented out RequestMethod.GET from MIGRATED_REST_METHODS in app.module.ts to indicate work in progress

6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant