[BUGFIX] Call and await destroyDataSourceForWorkspace to avoid killing poor pod
#10364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds critical fixes to database connection cleanup across multiple upgrade commands by properly awaiting the destroyDataSourceForWorkspace calls.
- Added
awaittodestroyDataSourceForWorkspacecalls in six upgrade command files to prevent premature database connection termination - Ensures proper cleanup of database resources after workspace processing in
0-42-limit-amount-of-view-field.ts - Fixes potential memory leaks and resource exhaustion in
0-42-fix-body-v2-view-field-position.command.ts - Maintains connection cleanup even during error scenarios in
0-41-remove-duplicate-mcmas.ts - Prevents pod termination issues by properly closing connections in
0-41-seed-workflow-views.command.ts
6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
.../twenty-server/src/database/commands/upgrade-version/0-42/0-42-limit-amount-of-view-field.ts
Outdated
Show resolved
Hide resolved
...r/src/database/commands/upgrade-version/0-42/0-42-fix-body-v2-view-field-position.command.ts
Show resolved
Hide resolved
ijreilly
approved these changes
Feb 20, 2025
|
Thanks @prastoin for your contribution! |
prastoin
added a commit
that referenced
this pull request
Feb 20, 2025
…ing poor pod (#10364) # Motivations Upgrade migration is not possible atm in production because running over all workspaces cause cpu raise leading to pod termination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Upgrade migration is not possible atm in production because running over all workspaces cause cpu raise leading to pod termination