[permissions] Place lab + billing behind settings/workspace permission gates #10354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added permission gates to lab and billing functionality, requiring workspace settings permissions for access and modifications.
- Added
PermissionsModuletopackages/twenty-server/src/engine/core-modules/billing/billing.module.tsandlab.module.tsfor permission control - Added
SettingsPermissionsGuardwithWORKSPACEfeature requirement tobilling.resolver.tsandlab.resolver.ts - Added permission check for Lab section in
useSettingsNavigationItems.tsx, requiring both lab feature flags and workspace permissions - Added comprehensive integration tests in
workspace.integration-spec.tsandsecurity.integration-spec.tsto verify permission gates - Protected billing portal and lab feature flag updates with proper role-based access controls
8 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+347
to
348
| describe('updateBillingSubscription', () => { | ||
| it('should throw a permission error when user does not have permission (member role)', async () => { |
There was a problem hiding this comment.
logic: Test name 'updateBillingSubscription' doesn't match the actual test (BillingPortalSession). Either the test name or the test content needs to be updated.
Suggested change
| describe('updateBillingSubscription', () => { | |
| it('should throw a permission error when user does not have permission (member role)', async () => { | |
| describe('billingPortalSession', () => { | |
| it('should throw a permission error when user does not have permission (member role)', async () => { |
...ty-server/test/integration/graphql/suites/settings-permissions/workspace.integration-spec.ts
Show resolved
Hide resolved
Comment on lines
+380
to
378
| describe('billingPortalSession', () => { | ||
| it('should throw a permission error when user does not have permission (member role)', async () => { |
There was a problem hiding this comment.
style: Duplicate test case - billingPortalSession test is identical to updateBillingSubscription test above
Comment on lines
+320
to
+326
| mutation DeleteCurrentWorkspace { | ||
| deleteCurrentWorkspace { | ||
| id | ||
| __typename | ||
| } | ||
| } | ||
| `, |
There was a problem hiding this comment.
style: GraphQL mutation indentation is inconsistent with rest of file
ijreilly
force-pushed
the
perm--billing-lab-gates
branch
from
2e13317 to
95d3f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.