Display confirmation dialog on connected account deletion #10323
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added confirmation modal to prevent accidental deletion of connected accounts in the settings interface.
- Added
isDeleteAccountModalOpenstate anddeleteAccounthandler inpackages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsRowDropdownMenu.tsx - Integrated
ConfirmationModalcomponent with appropriate title and subtitle for account deletion confirmation - Follows existing patterns seen in workspace and user account deletion implementations
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| const deleteAccount = async () => { | ||
| await destroyOneRecord(account.id); | ||
| setIsDeleteAccountModalOpen(false); | ||
| }; |
There was a problem hiding this comment.
style: closeDropdown() should be called after successful deletion to ensure proper UI cleanup
There was a problem hiding this comment.
The component gets destroyed on deletion so I don't think the closeDropwdown is required in this particular case
There was a problem hiding this comment.
It's not a big deal but I think it's best to close the dropdown in every case (not just on success as Greptile suggests). Here it seems the click on "cancel" also closes the dropdown but that might not always be the case if we refactor to separate the modal layer from the underlying layer, I'm not sure it's a desired side effect
alexmotoc
changed the title
Fairly straightforward change, it's my first contribution in this project so tried to follow the existing patterns.
I couldn't find any component tests or e2e Playwright tests touching this area to update - happy to write some from scratch if necessary!
Closes #10285