Fix command menu context chip display on show page #10267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves the command menu context chip display for new and existing records, particularly focusing on show pages for Companies and Tasks.
- Added
isNewRecordparameter inopenRecordInCommandMenuto properly display "New" prefix in titles for newly created records - Modified
CommandMenuContextChipGroupsWithRecordSelectionto handle empty record selections without breaking the UI - Integrated dynamic icon handling based on object metadata for consistent record type visualization
- Improved state management between command menu and right drawer interactions for better UX
- Added i18n support for "New" record titles in the command menu
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
thomtrp
approved these changes
Feb 17, 2025
Weiko
deleted the
r--fix-command-menu-context-chip-display-on-show-page
branch
| pageIcon: IconList, | ||
| pageTitle: isNewRecord | ||
| ? t`New ${capitalizedObjectNameSingular}` | ||
| : capitalizedObjectNameSingular, |
There was a problem hiding this comment.
I think that the objectNameSingular is already translated but I'm not sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Company
Before:
After:
Task
Before:
After: