[NITPICK] call closeDropdown before openModal import spreadsheet
#10254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the order of operations in the dropdown menu's Import functionality to ensure proper UI state management.
- Changed
onClickhandler in/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownMenuContent.tsxto close dropdown before opening import dialog
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
prastoin
changed the title
closeDropdown before openModalcloseDropdown before openModal import spreadsheet
charlesBochet
approved these changes
Feb 17, 2025
|
Thanks @prastoin for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Just a nitpick resulting from #10205
Avoid any possible race condition between competing event handlers by closing dropdown before opening modal