Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBSITE] Upgrade guide 0.41.0 -> 0.42.0 #10231

Merged
merged 2 commits into from
Feb 15, 2025
Merged

[WEBSITE] Upgrade guide 0.41.0 -> 0.42.0 #10231

merged 2 commits into from
Feb 15, 2025

Conversation

prastoin
Copy link
Contributor

@prastoin prastoin commented Feb 15, 2025

Introduction

Upgrade guide from 0.41.0 to 0.42.0

Note

@guillim I've been searching for references to the new env vars added in the Microsoft scope to the version to the setup.mdx page, unless I'm mistaken IS_MICROSOFT_SYNC_ENABLED seems to be missing ? I'm not sure if it's required or not and on where to add it within the page, could you please give it a look 🙏 ?

@prastoin prastoin marked this pull request as ready for review February 15, 2025 07:29
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the upgrade guide for version 0.42.0, but reveals a documentation gap regarding Microsoft integration environment variables.

  • Missing documentation for IS_MICROSOFT_SYNC_ENABLED in /packages/twenty-website/src/content/developers/self-hosting/setup.mdx
  • Should be added to the Auth section of setup.mdx alongside other Microsoft-related variables
  • Recommend adding it with other Microsoft integration variables like MESSAGING_PROVIDER_MICROSOFT_ENABLED and CALENDAR_PROVIDER_MICROSOFT_ENABLED
  • Consider grouping all Microsoft-related environment variables together for better organization

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@prastoin prastoin requested a review from guillim February 15, 2025 07:37
**Environment Variables**

- Removed: `FRONT_PORT`, `FRONT_PROTOCOL`, `FRONT_DOMAIN`, `PORT`
- Added: `FRONTEND_URL`, `NODE_PORT`
- Added: `FRONTEND_URL`, `NODE_PORT`, `MAX_NUMBER_OF_WORKSPACES_DELETED_PER_EXECUTION`, `BILLING_FREE_TRIAL_WITHOUT_CREDIT_CARD_DURATION_IN_DAYS`, `BILLING_FREE_TRIAL_WITH_CREDIT_CARD_DURATION_IN_DAYS`, `MESSAGING_PROVIDER_MICROSOFT_ENABLED`, `CALENDAR_PROVIDER_MICROSOFT_ENABLED`, `IS_MICROSOFT_SYNC_ENABLED`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo no need to document Billing related changes as they are purely for internal use-case.

Also I think it's okay for this but for future release, I think it'd be best to give context for each variable.
E.g. "We removed FRONT_PORT and FRONT_PROTOCOL to replace it by a single variable FRONTEND_URL, that variable is now optional and will default to the SERVER_URL so there is no need to set it if your frontend is hosted on the same url as the backend."

@prastoin prastoin merged commit f795d90 into main Feb 15, 2025
32 checks passed
@prastoin prastoin deleted the upgrade-0.41-0.42 branch February 15, 2025 08:11
Copy link
Contributor

Thanks @prastoin for your contribution!
This marks your 40th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

eliezer-rodrigues037 pushed a commit to mind-developer/kvoip-v2 that referenced this pull request Feb 17, 2025
# Introduction
Upgrade guide from 0.41.0 to 0.42.0

## Note
@guillim I've been searching for references to the new `env vars` added
in the Microsoft scope to the version to the `setup.mdx` page, unless
I'm mistaken `IS_MICROSOFT_SYNC_ENABLED` seems to be missing ? I'm not
sure if it's required or not and on where to add it within the page,
could you please give it a look 🙏 ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants