Display object name plural instead of object #10228
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the command menu by replacing the generic 'Object' label with the plural form of the current object's name, providing more context-aware navigation.
- Added object metadata state management in
/packages/twenty-front/src/modules/command-menu/components/CommandMenu.tsxto fetch and display plural object names - Implemented fallback to 'Object' label when metadata is unavailable for graceful degradation
- Utilized
useObjectNamePluralFromSingularhook for consistent object name handling across the application
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| const objectMetadataItems = useRecoilValue(objectMetadataItemsState); | ||
| const currentObjectMetadataId = useRecoilComponentValueV2( | ||
| contextStoreCurrentObjectMetadataIdComponentState, | ||
| ); | ||
|
|
||
| const currentObjectMetadataItem = objectMetadataItems.find( | ||
| (objectMetadataItem) => objectMetadataItem.id === currentObjectMetadataId, | ||
| ); |
There was a problem hiding this comment.
style: Consider memoizing this find operation with useMemo to prevent unnecessary recalculations on re-renders
| @@ -54,6 +55,15 @@ export const CommandMenu = () => { | |||
| 'command-menu-previous', | |||
| ); | |||
|
|
|||
| const objectMetadataItems = useRecoilValue(objectMetadataItemsState); | |||
| const currentObjectMetadataId = useRecoilComponentValueV2( | |||
There was a problem hiding this comment.
Nitpick: I was wondering if there were any existing hooks that were already doing that, the best I could find is objectMetadataItemFamilySelector which could be interesting to refactor adding granularity on objectMetadataItem.id which could fit our need here !
There was a problem hiding this comment.
The hooks that we normally use to retrieve objectMetadataItem are useObjectMetadataItemById or useObjectMetadataItem. The problem of these hooks is that they throw if objectMetadataItem is undefined. The command menu is one of the few places where the objectMetadataItem can be undefined, because we can open it on a settings page for instance. I wanted to introduce a hook which retrieves the objectMetadataItem but doesn't throw, and I discussed this issue a few time with @lucasbordeau and @charlesBochet.
bosiraphael
deleted the
r--display-object-name-plural-instead-of-object
branch
Display object name plural instead of 'Object' inside the command menu section related to the current object.
Display object name plural instead of 'Object' inside the command menu section related to the current object.