Fixing unhandled exception for microsoft driver #10223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances error handling for Microsoft Graph API batch requests, focusing on previously unhandled exceptions and improved error reporting.
- Added status code validation in
microsoft-handle-error.service.tsto catch undefined GraphError status codes - Enhanced batch response parsing in
microsoft-get-messages.service.tsto include both error details and status codes - Modified
handleTemporaryExceptioninmessage-import-exception-handler.service.tsto throwMessageImportExceptionwhen throttle failures exceed max attempts - Added error object structure standardization across Microsoft batch requests for better debugging
- Improved error propagation in batch processing to prevent silent failures
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...essaging/message-import-manager/drivers/microsoft/services/microsoft-handle-error.service.ts
Show resolved
Hide resolved
|
Thanks @guillim for your contribution! |
prastoin
pushed a commit
that referenced
this pull request
Feb 14, 2025
Fixing a difficult bug: an unhandled exception for microsoft driver when one of the many Microsoft BATCH request failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a difficult bug: an unhandled exception for microsoft driver when one of the many Microsoft BATCH request failed.