Update suspended cleaning command #10195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a refined three-stage workspace cleanup process with improved handling of inactive workspaces.
- Added soft deletion phase between notification and permanent deletion in
.env.example, with timeframes of 7 days (notification), 14 days (soft delete), and 21 days (permanent delete) - Modified
UserWorkspaceentity to use@DeleteDateColumnfor proper TypeORM soft delete functionality - Added
withDeleted: trueoption in workspace queries to ensure processing of both active and soft-deleted suspended workspaces - Added
dryRunparameter and improved error handling in cleaner service for safer testing and execution - Fixed critical logical error in
CleanSuspendedWorkspacesCommandwhere incorrect variable is passed tobatchWarnOrCleanSuspendedWorkspaces
8 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-server/src/engine/core-modules/environment/environment-variables.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/environment/environment-variables.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/user-workspace/user-workspace.entity.ts
Show resolved
Hide resolved
...-server/src/engine/workspace-manager/workspace-cleaner/services/cleaner.workspace-service.ts
Outdated
Show resolved
Hide resolved
...-server/src/engine/workspace-manager/workspace-cleaner/services/cleaner.workspace-service.ts
Show resolved
Hide resolved
...rc/engine/workspace-manager/workspace-cleaner/commands/clean-suspended-workspaces.command.ts
Outdated
Show resolved
Hide resolved
etiennejouan
changed the title
Weiko
reviewed
Feb 13, 2025
packages/twenty-server/src/engine/core-modules/environment/environment-variables.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/user-workspace/user-workspace.entity.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts
Show resolved
Hide resolved
Weiko
approved these changes
Feb 14, 2025
|
Thanks @etiennejouan for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes twentyhq/core-team-issues#382