Show a workspace image placeholder if no logo has been uploaded

[Bonapara]

Current behavior

Nothing is displayed when no workspace icon has been set

Desired Behavior

Display a 16px icon placeholder

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=436-22577&node-type=frame&t=1MbeI6xDAAaFJjM2-11

[muraliSingh7]

@Bonapara if logo is undefined currently we have something called as DEFAULT_WORKSPACE_LOGO. If you want to display 16px placeholder we can use Avatar for it instead of DEFAULT_WORKSPACE_LOGO.

[Bonapara]

Yes we can replace the default logo with the avatar!

[muraliSingh7]

@Bonapara So should I fix it ?

[Bonapara]

Yes please @muraliSingh7!

[Bonapara]

Thanks for contributing

[muraliSingh7]

@Bonapara Can I commit the fix for this issue to my existing pull request, or should I wait until the current PR of mine for another issue gets reviewed ?

[Bonapara]

Thanks @muraliSingh7. I think doing another PR for easier and faster review would be better!

[muraliSingh7]

@Bonapara Please check once and close the issue as the PR for this issue has been merged

[Bonapara]

@muraliSingh7, in local, removing the "Acme" icon put the Twenty icon back 🤔 Maybed did I miss something?

"

[muraliSingh7]

@Bonapara
Can you confirm if Acme icon is set up via twenty/packages/twenty-server/src/database/typeorm-seeds/core/workspaces.ts at line 45 ?

[Bonapara]

Yes! } = {
[SEED_APPLE_WORKSPACE_ID]: {
id: workspaceId,
displayName: 'Apple',
domainName: 'apple.dev',
subdomain: 'apple',
inviteHash: 'apple.dev-invite-hash',
logo: 'https://twentyhq.github.io/placeholder-images/workspaces/apple-logo.png',
activationStatus: WorkspaceActivationStatus.ACTIVE,
},
[SEED_ACME_WORKSPACE_ID]: {
id: workspaceId,
displayName: 'Acme',
domainName: 'acme.dev',
subdomain: 'acme',
inviteHash: 'acme.dev-invite-hash',
logo: 'https://logos-world.net/wp-content/uploads/2022/05/Acme-Logo-700x394.png',
activationStatus: WorkspaceActivationStatus.ACTIVE,
},
};

[charlesBochet]

I've made a follow up here: #9129

[muraliSingh7]

@Bonapara , could you please verify whether @charlesBochet has resolved the issue or not ? If it has been addressed, kindly close the issue. Thank you!