Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile Picture - File not found in Settings #8601

Closed
Bonapara opened this issue Nov 20, 2024 · 5 comments · Fixed by #8942
Closed

Profile Picture - File not found in Settings #8601

Bonapara opened this issue Nov 20, 2024 · 5 comments · Fixed by #8942
Assignees
@charlesBochet
Labels
for experienced contributor prio: high scope: front Issues that are affecting the frontend side only

Comments

@Bonapara
Copy link
Member

Current behavior

{"error":"File not found"} when connected with Google

Image
@Bonapara Bonapara added for experienced contributor prio: high scope: front Issues that are affecting the frontend side only labels Nov 20, 2024
@Bonapara
Copy link
Member Author

@Weiko doesn't seem related to the issue we fixed the other day 🤔

@charlesBochet charlesBochet self-assigned this Nov 26, 2024
@charlesBochet charlesBochet moved this from 🆕 New to 🔖 Planned in 🎯 Roadmap & Sprints Nov 26, 2024
@charlesBochet charlesBochet moved this from 🔖 Planned to 🏗 In progress in 🎯 Roadmap & Sprints Nov 27, 2024
@charlesBochet charlesBochet moved this from 🏗 In progress to 🔖 Planned in 🎯 Roadmap & Sprints Nov 29, 2024
@charlesBochet
Copy link
Member

Adding this case too
Image

@mdrazak2001
Copy link
Contributor

mdrazak2001 commented Dec 2, 2024 •
edited
Loading

Hi @charlesBochet @Bonapara ,
The issue lies in the getImageAbsoluteURI utility. There are multiple versions in the codebase. The correct one appends query parameters directly, while the buggy one uses new URL() and toString(), which encodes ? as %3F, breaking URLs.

Would you like me to create a PR to fix this issue?

@mdrazak2001 mdrazak2001 mentioned this issue Dec 3, 2024
Merged
mdrazak2001 added a commit to mdrazak2001/twenty that referenced this issue Dec 4, 2024
@mdrazak2001
Add Twenty Shared package to centralize utilities and fix profile pic…
bcd7222 
…ture issue (twentyhq#8601).
mdrazak2001 added a commit to mdrazak2001/twenty that referenced this issue Dec 4, 2024
@mdrazak2001
Add Twenty Shared package to centralize utilities and fix profile pic…
5be9a09 
…ture issue (twentyhq#8601).
@charlesBochet charlesBochet moved this from 🔖 Planned to 🏗 In Progress in 🎯 Roadmap & Sprints Dec 6, 2024
@charlesBochet
Copy link
Member

Indeed @mdrazak2001 I agree it seems to be the root cause

@charlesBochet
Copy link
Member

charlesBochet commented Dec 7, 2024 •
edited
Loading

I have opened a PR here:
#8942

@charlesBochet charlesBochet mentioned this issue Dec 7, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in 🎯 Roadmap & Sprints Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlesBochet charlesBochet

Labels
for experienced contributor prio: high scope: front Issues that are affecting the frontend side only
Projects
🎯 Roadmap & Sprints
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken image urls in Settings > Profile and Invite To Workspace Email twentyhq/twenty
3 participants
@charlesBochet @Bonapara @mdrazak2001