Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user, when I add an email to a person, in show page, I see timeline "add email event" not properly formatted #8300

Closed
martmull opened this issue Nov 4, 2024 · 8 comments · Fixed by #8596
Closed

As a user, when I add an email to a person, in show page, I see timeline "add email event" not properly formatted #8300

martmull opened this issue Nov 4, 2024 · 8 comments · Fixed by #8596
Assignees
@Weiko
Labels
for experienced contributor scope: backend Issues that are affecting the backend side only

Comments

@martmull
Copy link
Contributor

martmull commented Nov 4, 2024 •
edited
Loading

Bug Description

  • create a user
  • add an email
  • go to user show page
  • see issue in timeline
    image
  • if i add an aditional email, the additional emails are poorly rendered
    image
image

Expected behavior

No [ ] visible for composite fields

Technical input

  • for composite fields, arrays are returned as strings not as array in FindManyTimelineActivities. In the front, they are expected to be array. We might fix backend so it returns a proper array
image
@martmull martmull added the good first issue Good for newcomers label Nov 4, 2024
@martmull martmull assigned martmull and unassigned martmull Nov 4, 2024
@Bonapara
Copy link
Member

Bonapara commented Nov 4, 2024

Related to #8264

@yashkhokhar28
Copy link

I would like to work on it.

@Bonapara
Copy link
Member

Bonapara commented Nov 5, 2024

Sure @yashkhokhar28! Please have a look to the related issue. Thanks for contributing!

@martmull martmull added the scope: backend Issues that are affecting the backend side only label Nov 5, 2024
@yashkhokhar28 yashkhokhar28 mentioned this issue Nov 6, 2024
Closed
@sarvagyakrcs
Copy link

I would like to work on it

@FelixMalfait
Copy link
Member

@ad-elias would you mind having a look at this one later? Thank you!

@ad-elias
Copy link
Contributor

@FelixMalfait Sure!

@martmull martmull self-assigned this Nov 18, 2024
@martmull martmull moved this from 🆕 New to 🔖 Planned in Product development ✅ Nov 18, 2024
@FelixMalfait
Copy link
Member

@ad-elias as discussed, let's let Martin do it since he assigned himself

@martmull martmull assigned Weiko and unassigned martmull Nov 19, 2024
@martmull
Copy link
Contributor Author

too hard for me, giving that to @Weiko

@Weiko Weiko mentioned this issue Nov 19, 2024
Merged
charlesBochet pushed a commit that referenced this issue Nov 21, 2024
@Weiko
[Flexible-schema] Refactor gql query runner to emit api event before …
1c04b2b 
…processing to gql types (#8596)

Fixes #8300

## Context
API events were created too late and were already formatted as Gql
responses (including nesting with edges/node/type + formatting that
should not exist in an event payload). This PR moves the emit logic to
the resolver where we actually do the DB query
Note: Also added RESTORED events
@github-project-automation github-project-automation bot moved this from 🔖 Planned to ✅ Done in Product development ✅ Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Weiko Weiko

Labels
for experienced contributor scope: backend Issues that are affecting the backend side only
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
8 participants
@Weiko @FelixMalfait @Bonapara @lucasbordeau @martmull @yashkhokhar28 @sarvagyakrcs @ad-elias