Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glitch when searching relation picker #7957

Closed
Bonapara opened this issue Oct 22, 2024 · 14 comments
Closed

Glitch when searching relation picker #7957

Bonapara opened this issue Oct 22, 2024 · 14 comments
Labels
prio: med scope: front Issues that are affecting the frontend side only type: design improvement

Comments

@Bonapara
Copy link
Member

Bug description

Relation picker is flashing each time a new letter is getting typed

CleanShot.2024-10-22.at.15.58.39.mp4

How to reproduce

Type anything in a relation picker
@Bonapara Bonapara added scope: front Issues that are affecting the frontend side only type: design improvement prio: med labels Oct 22, 2024
@Bonapara
Copy link
Member Author

Related to #7511?

@sans-byte
Copy link
Contributor

sans-byte commented Oct 24, 2024 •
edited
Loading

Hi, I have solved this issue can I raise a PR for this? @Bonapara Please assign it to me

Screen.Recording.2024-10-24.at.6.27.45.PM.mov

is this correct?

@ehconitin
Copy link
Contributor

@sans-byte yes please!

@Weiko Weiko assigned sans-byte and unassigned ehconitin Oct 24, 2024
@sans-byte sans-byte mentioned this issue Oct 24, 2024
Closed
@ehconitin
Copy link
Contributor

@sans-byte Could u type 'opp' in the filter and share the recording?
Like one by one? O p p

@FelixMalfait
Copy link
Member

Made a comment in the PR, thanks a lot for the effort but I don't think that's what we want

@sans-byte
Copy link
Contributor

sans-byte commented Oct 24, 2024 •
edited
Loading

Screen.Recording.2024-10-24.at.8.53.21.PM.mov

@FelixMalfait is this one better ? I took your suggestion of result -> white -> result and also tested it for different size results, I have added a loading skeleton

@FelixMalfait
Copy link
Member

@sans-byte thanks but no it's stil blinking each time you type a letter :), we want to avoid that

@sans-byte
Copy link
Contributor

Yeah, each time we type a letter request is going out which is getting it into a loading state, I can fix it by introducing small debounce on input.
Or else can you please suggest me how to fix it? @FelixMalfait

@FelixMalfait
Copy link
Member

We don't want a debounce, that would be a hack :) ; I don't know this component well enough but we should probably remove a condition that hides results based on the loading state or something like that

@sans-byte
Copy link
Contributor

sans-byte commented Oct 24, 2024 •
edited
Loading

Screen.Recording.2024-10-24.at.10.26.42.PM.mov

Please take a look @FelixMalfait

@FelixMalfait
Copy link
Member

That looks much better @sans-byte! Curious to see the code

@sans-byte
Copy link
Contributor

Sure will raise the PR

This was referenced Oct 24, 2024
Closed
Merged
FelixMalfait added a commit that referenced this issue Oct 25, 2024
@sans-byte @FelixMalfait
fix glitch for relation picker search (#8040)
9c923ba 
Fix for #7957

---------

Co-authored-by: Félix Malfait <[email protected]>
@sans-byte sans-byte removed their assignment Nov 4, 2024
@harshrajeevsingh
Copy link
Contributor

@FelixMalfait This can be closed now.

@FelixMalfait
Copy link
Member

thanks!

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio: med scope: front Issues that are affecting the frontend side only type: design improvement
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@FelixMalfait @Bonapara @harshrajeevsingh @sans-byte @ehconitin