Issue with Email Validation and API Call Trigger on Login

[Karankhatik]

Bug Description

Explanation:

1. Email Validation Not Strict Enough: The current system allows invalid email formats, causing the API to be triggered unnecessarily. The system should only send API requests when the email input matches a valid email format.
2. Password Field Displayed Even for Non-existent Users: After the API returns a "user not found" message, the password input field still appears, which is misleading.
3. Sign-up Button Disabled Despite Invalid State: Even though the user doesn't exist, the sign-up button remains disabled, which should be enabled to encourage user registration.

The issue was tested across Brave, Chrome, and Firefox, indicating it is system-specific and not related to browser differences.

twentylogin-bug.webm

[Karankhatik]

@Bonapara Please give me the green flag to work on this issue. Thank you!

[Bonapara]

Hi @Karankhatik, thanks for raising this issue! I understand points 1 and 2, but not point 3. The button is expected to remain disabled while the fields are incomplete. What would you suggest?

[Karankhatik]

@Bonapara Thanks for the reply, Even when the fields are filled, like with an invalid email and a password, it can be misleading.

The correct flow should be:

1. Strictly validate the email format then go to the second step.
2. Call the API to check if the input email corresponds to a registered user. If the user exists, display the password field; otherwise, show a toaster notification that the user or email does not exist.
3. Finally, show the "Sign In" button, which should remain disabled until the user enters a valid password.

Please let me know your thoughts!

[Bonapara]

The behavior we have today is that if the email entered in step 1 is not recognized as a user, the flow redirects to the sign-up page. We use the same process for both sign-in and sign-up use cases. So we should not implement 2) & 3)

But we can implement 1) -> Strictly validate the email format then go to the second step that sounds like a great idea!

[Karankhatik]

sure I will work on this.

[Bonapara]

/oss.gg 150

[oss-gg]

Thanks for opening an issue! It's live on oss.gg!

[vamsi-duvvana]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[aryanbansal73]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[HarshBytesCode]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[no-naame]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[vamsi4845]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[Rajan3208]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[Vishwa1011IIITM]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[charlesBochet]

/unassign

[oss-gg]

Issue unassigned.

[Sahil873]

/assign

[oss-gg]

Assigned to @Sahil873! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[HarshBytesCode]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[charlesBochet]

/unassign

[oss-gg]

Issue unassigned.

[Khaan25]

/assign

[oss-gg]

You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more.

[Khaan25]

@charlesBochet Can I work on this please?

[Khaan25]

@FelixMalfait Can I work on this please?

[Bonapara]

Replacing this issue by #7967 to clear the discussion output. Thanks @Karankhatik for opening it. @Khaan25 comment the issue if you still want to handle it.