Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhooks chevron is not on the right edge enough #7403

Closed
Bonapara opened this issue Oct 2, 2024 · 12 comments · Fixed by #7438
Closed

Webhooks chevron is not on the right edge enough #7403

Bonapara opened this issue Oct 2, 2024 · 12 comments · Fixed by #7438
Assignees
@Vardhaman619
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Bonapara commented Oct 2, 2024

Current behavior

The webhook list chevron right in Settings > Developers are too much on the left

2eb1abd382a3eaff2249a150ca9ffc3b9a1ea297903a21055bd04fea1b12f3aa

Desired Behavior

They should be only 4px to the right edge of the table

708578e737a4621d06bbaa6ffc3e2eaa35115252b51ce06c159c360c9a1c1ada
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement prio: med 🕹️ oss.gg labels Oct 2, 2024
@thezeeshann
Copy link

@Bonapara Hey man can I work on this issue?

@Bonapara
Copy link
Member Author

Bonapara commented Oct 2, 2024

Yes thanks for contributing @thezeeshann!

@Bonapara
Copy link
Member Author

Bonapara commented Oct 2, 2024

This also occurs on the API key table:

e75be7ef5e468d6c550f353a2de383e549a674735c5d32c402fb2126ddf83fc2

@Vardhaman619
Copy link
Contributor

@Bonapara I would like to work on this issue

@Bonapara
Copy link
Member Author

Bonapara commented Oct 4, 2024

Sorry @Vardhaman619, @thezeeshann is already on it. Maybe can you grab another Good First Issue? Thanks

@thezeeshann
Copy link

@Bonapara is there any doc file to set the project locally? struggling to setup a project.

@Vardhaman619
Copy link
Contributor

@Bonapara is there any doc file to set the project locally? struggling to setup a project.

https://twenty.com/developers/local-setup

@Bonapara
Copy link
Member Author

Bonapara commented Oct 4, 2024

@Bonapara is there any doc file to set the project locally? struggling to setup a project.

On https://docs.twenty.com/ or on our Discord #help channel!

@Vardhaman619
Copy link
Contributor

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 4, 2024

Assigned to @Vardhaman619! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Vardhaman619 Vardhaman619 mentioned this issue Oct 4, 2024
Merged
@Shaik-mohd-huzaifa
Copy link

Can you Assign me this issue?

@Bonapara
Copy link
Member Author

Bonapara commented Oct 6, 2024

Sorry @Shaik-mohd-huzaifa, @Vardhaman619 is already on it. Maybe can you grab another Good First Issue? Thanks

martmull pushed a commit that referenced this issue Oct 8, 2024
@Vardhaman619 @charlesBochet @ehconitin
Fix: Adjust chevron alignment to the right edge (#7438)
10e7517 
This pull request addresses the alignment issue of the chevron icon,
ensuring that it is positioned correctly on the right edge.
Fixes [#7403](#7403)

![after
fix](https://github.com/user-attachments/assets/84e6cd14-1d10-4331-8f25-da5423b15dd3)

---------

Co-authored-by: Charles Bochet <[email protected]>
Co-authored-by: ehconitin <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Oct 8, 2024
harshit078 pushed a commit to harshit078/twenty that referenced this issue Oct 14, 2024
@Vardhaman619 @charlesBochet
@ehconitin @harshit078
Fix: Adjust chevron alignment to the right edge (twentyhq#7438)
6d657fe 
This pull request addresses the alignment issue of the chevron icon,
ensuring that it is positioned correctly on the right edge.
Fixes [twentyhq#7403](twentyhq#7403)

![after
fix](https://github.com/user-attachments/assets/84e6cd14-1d10-4331-8f25-da5423b15dd3)

---------

Co-authored-by: Charles Bochet <[email protected]>
Co-authored-by: ehconitin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vardhaman619 Vardhaman619

Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Adjust chevron alignment to the right edge Vardhaman619/twenty
4 participants
@Bonapara @Shaik-mohd-huzaifa @thezeeshann @Vardhaman619