Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set field type icon as default new field icon #7352

Closed
Bonapara opened this issue Sep 30, 2024 · 9 comments · Fixed by #7579
Closed

Set field type icon as default new field icon #7352

Bonapara opened this issue Sep 30, 2024 · 9 comments · Fixed by #7579
Assignees
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Bonapara commented Sep 30, 2024

Current Behavior

Currently, we display the users icon as the default field icon:

b8c9b17d652d8528cd2bb96b0f5278b1ac59fe9210cfbbfc0cd1600561fbf692

Desired Behavior

We would like to use the field type Tabler icons as the default icon:

  • Typography as the default icon for the Text field type
  • Mail as the default icon for the Emails field type
  • ...

Example:

CleanShot 2024-09-30 at 16 28 47

Icon name list:

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=36855-126980&node-type=frame&t=YZppWDu8cDmzxDmJ-11

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement prio: med labels Sep 30, 2024
@Bonapara Bonapara changed the title Set field type icon as default icon when creating a new field Set field type icon as default icon when creating a new field Sep 30, 2024
@Bonapara Bonapara changed the title Set field type icon as default icon when creating a new field Set field type icon as default new field icon Sep 30, 2024
@sachinks07
Copy link
Contributor

@Bonapara, I would like to work on this issue.

@Bonapara
Copy link
Member Author

Bonapara commented Oct 1, 2024

Sure @sachinks07, thanks for contributing!

@sahilambre
Copy link

@Bonapara , do you know if this is done? If not I would like to work on it.
Thanks

@Vardhaman619
Copy link
Contributor

@Bonapara If no one is currently working on this issue, I’d like to take it on. Could you assign it to me?

@sachinks07
Copy link
Contributor

I am working on it.

@sachinks07 sachinks07 removed their assignment Oct 5, 2024
@dostavic
Copy link
Contributor

dostavic commented Oct 7, 2024

I saw the issue is no assigned. I’d like to take it on if that’s okay

@Bonapara
Copy link
Member Author

Bonapara commented Oct 8, 2024

Sure @dostavic, thanks for contributing!

@dostavic
Copy link
Contributor

Question Regarding the Task:
I'm not sure if I understood the task correctly, because in the Figma design, the icons are colored, but in the screenshot, they are black and white (I used black and white). If any changes or adjustments are needed, please let me know.

Suggestions:
While setting up the environment on Manjaro, I encountered an issue: Postgres was freezing when run through Docker, and the local script doesn't work on Arch Linux. Perhaps we should add this script (I've already created it) and update the documentation.

@Bonapara
Copy link
Member Author

@dostavic Thanks for your comment. You're right; we used color icons for the field type, but we should use regular icons here. Both the blue and gray icons rely on Tabler icons.

For instance, the relation icon used should be this one: https://tabler.io/icons/icon/relation-one-to-many

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants