Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert optimistic response on 400/500 #7299

Closed
FelixMalfait opened this issue Sep 27, 2024 · 0 comments · Fixed by #7541
Closed

Revert optimistic response on 400/500 #7299

FelixMalfait opened this issue Sep 27, 2024 · 0 comments · Fixed by #7541
Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short type: chore

Comments

@FelixMalfait
Copy link
Member

When we send a request to the server which results in an error, the frontend ignores the error and the optimistic change that was applied remains.

Instead, I believe the default behavior should be to revert the changes that when optimistically applied upon receiving a negative response from the server.

Here's an example that happened on a feature I was working on to add a unicity constraint:

Screen.Recording.2024-09-27.at.17.25.24.mov
@FelixMalfait FelixMalfait mentioned this issue Oct 9, 2024
Merged
lucasbordeau pushed a commit that referenced this issue Oct 9, 2024
@FelixMalfait
Revert optimistic rendering on negative response (#7541)
be49d4f 
Fixes #7299

The changes primarily focus on ensuring that records are correctly
handled in the cache and optimistic effects are reverted appropriately
when mutations fail.
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Oct 9, 2024
harshit078 pushed a commit to harshit078/twenty that referenced this issue Oct 14, 2024
@FelixMalfait @harshit078
Revert optimistic rendering on negative response (twentyhq#7541)
c6bf184 
Fixes twentyhq#7299

The changes primarily focus on ensuring that records are correctly
handled in the cache and optimistic effects are reverted appropriately
when mutations fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short type: chore
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert optimistic rendering on negative response twentyhq/twenty
1 participant
@FelixMalfait