Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Floating Input Padding and Border Color #7286

Closed
Bonapara opened this issue Sep 27, 2024 · 5 comments
Closed

Adjust Floating Input Padding and Border Color #7286

Bonapara opened this issue Sep 27, 2024 · 5 comments
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Bonapara commented Sep 27, 2024 •
edited
Loading

Current Behavior

  • The floating input's left padding is too large (4px + 8px padding when the vertical padding is only 8px).
  • The border is too light.

fd020e3be8ca21f48d0164d4b6009c909ca8393281162f7a5d546520af354b61

Desired Behavior

  • Set the left-padding to 8px.
  • Change the border color to Borders/medium.

image

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=3007-69739&node-type=frame&t=yAzVtdp6KfcheBnI-11
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement prio: med labels Sep 27, 2024
@nganphan123
Copy link
Contributor

Hi @Bonapara , can I take this?

@nganphan123 nganphan123 mentioned this issue Sep 30, 2024
Merged
@Bonapara
Copy link
Member Author

Sure @nganphan123, thanks for contributing!

martmull pushed a commit that referenced this issue Oct 2, 2024
@nganphan123
Adjust Floating Input Padding and Border Color (#7328)
57eaa01 
This PR fix the padding and border color of floating text input #7286 
The text area automatically has padding of 4px so I reset it to 0 and
adjusting container padding to 8px.
@Supratim69
Copy link

Is this issue sorted? or is there something left to be done?

@Bonapara
Copy link
Member Author

Bonapara commented Oct 4, 2024

It looks like it was fixed indeed, thanks for notifying @Supratim69!

@ehconitin
Copy link
Contributor

closed in #7328

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Oct 10, 2024
harshit078 pushed a commit to harshit078/twenty that referenced this issue Oct 14, 2024
@nganphan123 @harshit078
Adjust Floating Input Padding and Border Color (twentyhq#7328)
a14bdaa 
This PR fix the padding and border color of floating text input twentyhq#7286 
The text area automatically has padding of 4px so I reset it to 0 and
adjusting container padding to 8px.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers prio: med scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Bonapara @nganphan123 @Supratim69 @ehconitin