Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking Outside Fields Should Close Them #7223

Closed
Bonapara opened this issue Sep 23, 2024 · 11 comments · Fixed by #7804
Closed

Clicking Outside Fields Should Close Them #7223

Bonapara opened this issue Sep 23, 2024 · 11 comments · Fixed by #7804
Labels
good first issue Good for newcomers prio: high scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Bug description

Clicking outside a domain, links, email, or phone field should close the field instead of opening the one clicked, replicating the standard behavior of other fields.

Current

CleanShot.2024-09-23.at.17.05.28.mp4

Desired

CleanShot.2024-09-23.at.17.06.10.mp4
@Bonapara Bonapara added type: bug good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement prio: high labels Sep 23, 2024
@varungujarathi9
Copy link

Hey I can work on this, can you please assign it to me

@Bonapara
Copy link
Member Author

Sure @varungujarathi9, thanks for contributing!

@maheswar-dileep
Copy link

maheswar-dileep commented Oct 11, 2024 •
edited
Loading

@varungujarathi9 are you still working on this ??
@Bonapara If not please assign it to me, Thanks.

@Bonapara
Copy link
Member Author

Bonapara commented Oct 11, 2024 •
edited
Loading

Hi @varungujarathi9, I am unassigning you as it has been two weeks. @maheswar-dileep, you can work on it. Thank you both for contributing!

@prathameshpatil5181
Copy link
Contributor

"Hi @Bonapara ,
I would like to contribute to this issue. May I work on it?"

@Bonapara
Copy link
Member Author

@maheswar-dileep are you still on it?

@maheswar-dileep
Copy link

@maheswar-dileep are you still on it?

Yes having some issues while setting up the project

@Bonapara
Copy link
Member Author

Okay, I'll let @prathameshpatil5181 handle this one if he's still interested, while you figure it out. :) I'll assign you another Good First Issue then

@prathameshpatil5181
Copy link
Contributor

Hi @Bonapara
Please assign it to me. i will be happy to work on this

@Bonapara
Copy link
Member Author

Thanks for contributing @prathameshpatil5181!

@prathameshpatil5181 prathameshpatil5181 mentioned this issue Oct 17, 2024
Merged
@oss-gg oss-gg bot mentioned this issue Oct 21, 2024
Closed
@prathameshpatil5181
Copy link
Contributor

Hi @Bonapara
Can you please unassign this issue as i alread fixed this.

lucasbordeau pushed a commit that referenced this issue Nov 7, 2024
@prathameshpatil5181
fix : 7223 Clicking Outside Fields domain link email phone Close Them (…
3be3065 
…#7804)

fixes #7223

https://github.com/user-attachments/assets/1150e96f-4fb5-40ba-ac17-89d8b2ab16e7
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers prio: high scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix : 7223 Clicking Outside Fields domain link email phone Close Them prathameshpatil5181/twenty
4 participants
@Bonapara @varungujarathi9 @prathameshpatil5181 @maheswar-dileep