Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filtering by ICP #7190

Closed
Sytten opened this issue Sep 20, 2024 · 14 comments
Closed

Allow filtering by ICP #7190

Sytten opened this issue Sep 20, 2024 · 14 comments
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@Sytten
Copy link

Sytten commented Sep 20, 2024

Scope & Context

Default account created a few days ago.

Current behavior

I can't filter on ICP (true/false) in compagnies.
Screenshot 2024-09-20 at 6 43 09 PM

Expected behavior

Please let me filter on ICP to I can find my leads!
@FelixMalfait
Copy link
Member

/oss.gg 200

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 14, 2024

Thanks for opening an issue! It's live on oss.gg!

@FelixMalfait
Copy link
Member

This is probably a missing configuration on the boolean filter type in the frontend

@FelixMalfait FelixMalfait added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only labels Oct 14, 2024
@sweets-11
Copy link

/assing

@VaibhavDhanani
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 15, 2024

Assigned to @VaibhavDhanani! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@0xnim
Copy link

0xnim commented Oct 15, 2024

If you dont finish it ill take it.

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 16, 2024

@VaibhavDhanani, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@DSK2307
Copy link

DSK2307 commented Oct 18, 2024

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 18, 2024

This issue is already assigned to another person. Please find more issues here.

@jayabha-jayas
Copy link
Contributor

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 25, 2024

This issue is already assigned to another person. Please find more issues here.

@FelixMalfait
Copy link
Member

@ad-elias would you mind also looking into this?

@ad-elias ad-elias mentioned this issue Nov 23, 2024
Merged
@VaibhavDhanani
Copy link

VaibhavDhanani commented Nov 23, 2024 •
edited
Loading

/unassign @VaibhavDhanani

FelixMalfait pushed a commit that referenced this issue Nov 24, 2024
@ad-elias
Add boolean filtering (#7190) (#8700)
bad7ad4 
<img width="956" alt="filter-icp-true"
src="https://github.com/user-attachments/assets/fc5fe18d-c7b6-463d-9ce7-8e5facb7352f">

Link to issue: #7190
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
8 participants
@Sytten @FelixMalfait @Bonapara @jayabha-jayas @0xnim @sweets-11 @VaibhavDhanani @DSK2307