Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear lastVisitedView when impersonating #7090

Closed
FelixMalfait opened this issue Sep 17, 2024 · 1 comment
Closed

Clear lastVisitedView when impersonating #7090

FelixMalfait opened this issue Sep 17, 2024 · 1 comment
Assignees
@ehconitin
Labels
prio: low scope: front Issues that are affecting the frontend side only size: short

Comments

@FelixMalfait
Copy link
Member

To help debug we built a function to impersonate users (who have not opted out for this feature in their settings).

We need to clear the LastVisitedViews stored in local storage whenever someone is impersonated (it doesn't matter if they are lost).
@FelixMalfait FelixMalfait added type: bug scope: front Issues that are affecting the frontend side only size: short prio: low labels Sep 17, 2024
@FelixMalfait
Copy link
Member Author

FelixMalfait commented Sep 17, 2024 •
edited
Loading

Actually it would make sense to clear the localStorage entirely maybe? we should probably share code with signout method instead of duplicating

@FelixMalfait FelixMalfait mentioned this issue Sep 17, 2024
Closed
@ehconitin ehconitin mentioned this issue Nov 25, 2024
Merged
FelixMalfait added a commit that referenced this issue Nov 28, 2024
@ehconitin @FelixMalfait
Admin panel init (#8742)
e96ad9a 
WIP
Related issues - 
#7090 
#8547 
Master issue - 
#4499

---------

Co-authored-by: Félix Malfait <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehconitin ehconitin

Labels
prio: low scope: front Issues that are affecting the frontend side only size: short
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FelixMalfait @Bonapara @ehconitin