When user tries to log in to workspace after token expiration, multiple errors appear

[BOHEUS]

I'm not sure if scenario is reproducible as I didn't try to repeat it but here's what I did:

1. Log in
2. In Settings > Developers generate new key (save it for later)
3. In Settings > Developers add webhook URL
4. Using Twenty docs, create simple bash script for creating 1 million companies effectively spamming REST API (or use attached script but change file format to .sh and replace key) and run it for few minutes till 1000 companies are created
5. Wait for token expiration (~30 min)
6. Try to log in

Actual: When user tries to log in to workspace with more than 1000 companies after token expiration, multiple errors appear
Screencast from 2024-08-24 17-41-14.webm

Expected: When user tries to log in to workspace with more than 1000 companies after token expiration, user should be able to log in without any problems

Note: While on video there's clearly visible that Companies are deactivated, I don't think they're a necessary step to reproduce bug.

Script: 1companies.txt

[Bonapara]

@BOHEUS Can you reproduce it to help determine the root cause of this issue? Otherwise, I think I'll close it and keep the bug in mind since it's not really actionable. Thanks for pushing Twenty!

[BOHEUS]

Sure, I'll report back when token will expire

[BOHEUS]

I was able to reproduce it on newest version of repo (mistakenly also reported it in #6732), I can't really pinpoint it in the code but it's definitely something with Apollo and useManyFindRecords like shown in the video

[charlesBochet]

@BOHEUS I can reproduce, I'm working on the sign-in / token expirations issues, will ping you back!

[charlesBochet]

I have made the fix but haven't tried this case yet. Any chance you could retry on the 0.24?

[BOHEUS]

@charlesBochet I'll check once I have some time

[BOHEUS]

@charlesBochet I can still reproduce it on 0.24

[charlesBochet]

Ok so it's still there! Let's see if someone from the community can fix it. If not, we will take it under 0.31 release

[FelixMalfait]

@ad-elias will look into this

[FelixMalfait]

Seems like the table below is trying to fetch companies (the mocked table or real table?)

[FelixMalfait]

Maybe look around here? Is currentWorkspaceMember null? What happens onError?

See skip: xxx

Could also be linked to fetchMoreRecords?

Skip applying to the first query but not to fetchMore?