Webhook URL sanity check is too restrictive

[FreakyPenguin]

Hi everyone,

We just ran into this with our on-prem deployment for testing. The sanity check regex for an URL seems way too restrictive:

twenty/packages/twenty-front/src/utils/is-url.ts

Line 6 in 9a0c967

/^(https?:\/\/)?(www.)?[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-z]{2,63}\b([-a-zA-Z0-9@:%_+.~#?&//=]*)/i,

This precludes ip addresses, or hostnames without a tld and a number of other useful urls. I would suggest using something more generic here or adding a config option to override.

Thanks

[FelixMalfait]

Good point! Since it's on the frontend, if you're blocked by this you can probably do an API call directly (copy the curl in your Chrome network inspector for example and change the url to the one that wasn't accepted)

[AnanteshG]

Hi, I’d like to work on this issue.

[Weiko]

imho, there is no way to know 'google' is an url if we make the protocol (already the case) and the tld optionals. If we want to remove restrictions I wouldn't update the isUrl method (that could have impact in the rest of the app) but would remove the call to isUrl in the webhook section.