Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we add a custom field in data model, we should go back from origin page #6374

Closed
lucasbordeau opened this issue Jul 23, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@lucasbordeau
Copy link
Contributor

Scope & Context

Adding a custom field from a table by using the option dropdown.

Current behavior

When we add a custom field, and we go back by exiting settings, we land on the default page (companies) instead of the page we went from

Expected behavior

We want to go back to the page we added the custom field from, for example if we added the custom field from People table, we should go back on people table, same view, when we exit settings.

See how we use setNavigationMemorizedUrl

@Faisal-imtiyaz123
Copy link
Contributor

@lucasbordeau I would like to work here.

@ehconitin
Copy link
Contributor

@lucasbordeau

Have fixed the issue.
Please check PR 6399

@Faisal-imtiyaz123
Copy link
Contributor

Faisal-imtiyaz123 commented Jul 24, 2024

@ehconitin @lucasbordeau I think the proper conduct is to ask one if one is working on the issue when one has shown interest of working there even if it is unassigned. Otherwise it wastes one's time if he had made some progress on the issue.

@lucasbordeau
Copy link
Contributor Author

@Faisal-imtiyaz123 Sure, @ehconitin seems to be very motivated right now so we're glad that he's putting so much efforts in !

There are old good first issues that are still there to be taken :

bosiraphael pushed a commit that referenced this issue Aug 5, 2024
@lucasbordeau
Issue #6374 
Fixed the navigation state issue! I also found and resolved a similar
bug with the "Edit Fields" functionality. The
`setNavigationMemorizedUrl` state now correctly updates on navigation to
settings, ensuring users return to the correct page.

Please review.
@ehconitin
Copy link
Contributor

This issue can be closed, fixed in #6399

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants