Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avanced Settings: Custom API names for Select & Multi-Select Keys #6146

Closed
Bonapara opened this issue Jul 5, 2024 · 5 comments
Closed

Avanced Settings: Custom API names for Select & Multi-Select Keys #6146

Bonapara opened this issue Jul 5, 2024 · 5 comments
Assignees
@gitstart-twenty
Labels
scope: back+front Issues requiring full-stack knowledge size: short

Comments

@Bonapara
Copy link
Member

Bonapara commented Jul 5, 2024

Current behavior

Users cannot edit the API Keys of Select and Multi-Select

image

Desired Behavior

image

Enabling the Advanced Mode in Settings for new Select fields should display a column that allows users to edit the Select API keys.

Figma

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=34851-536975&t=H5hfHOgNoulsToAq-11
@Bonapara Bonapara added scope: back+front Issues requiring full-stack knowledge size: short labels Jul 5, 2024
This was referenced Jul 5, 2024
Closed
Closed
Closed
@Bonapara Bonapara mentioned this issue Sep 12, 2024
Closed
@sid0-0 sid0-0 mentioned this issue Sep 13, 2024
Closed
@gitstart-connector GitStart Connector
Copy link

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-6146

@twentyhq twentyhq deleted a comment from greptile-apps bot Sep 18, 2024
@gitstart-app gitstart-app bot mentioned this issue Oct 8, 2024
Merged
@lucasbordeau
Copy link
Contributor

lucasbordeau commented Oct 8, 2024 •
edited
Loading

I suggest that we change the naming to API VALUES because API_KEYS is conflicting with the well known wording API Keys that allows people to authenticate to any API.

@Bonapara
Copy link
Member Author

Bonapara commented Oct 8, 2024

What about API_ID? Is it really "Values" @lucasbordeau?

ijreilly added a commit that referenced this issue Oct 11, 2024
@gitstart-app @gitstart-twenty @ijreilly
Avanced Settings: Custom API names for Select & Multi-Select Keys (#7489
7ceaa87 
)

### Description

- text input was changed because it renders an empty div as the right
icon, but the margin and padding affect the layout
- we have duplicated code on ExpandedWidthAnimationVariants.ts, because
of an eslint rule that prevents more than one const definition, can we
ignore the rule?
- 

### Demo


<https://www.loom.com/share/17a37bf5549a4a23ba12343b6046ec6b?sid=4cf297f3-66db-44c9-9a9b-7bde89b90d02>

### Refs

<#6146>

---------

Co-authored-by: gitstart-twenty <[email protected]>
Co-authored-by: gitstart-twenty <[email protected]>
Co-authored-by: Marie Stoppa <[email protected]>
@lucasbordeau
Copy link
Contributor

Yes both work.

@ijreilly
Copy link
Collaborator

done in #7489

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitstart-twenty gitstart-twenty

Labels
scope: back+front Issues requiring full-stack knowledge size: short
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Allow defining option key also in custom select options sid0-0/twenty
4 participants
@Bonapara @lucasbordeau @ijreilly @gitstart-twenty