Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Compact View" Toggle from L2 Kanban Option Menu #6116

Closed
Bonapara opened this issue Jul 3, 2024 · 6 comments · Fixed by #6453
Closed

Remove "Compact View" Toggle from L2 Kanban Option Menu #6116

Bonapara opened this issue Jul 3, 2024 · 6 comments · Fixed by #6453
Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short

Comments

@Bonapara
Copy link
Member

Bonapara commented Jul 3, 2024

Current Behavior

The "Compact view" toggle is visible on every Kanban sub-option menu (like the Fields menu and Fields > Hidden Fields).

CleanShot.2024-07-03.at.17.47.27.mp4

Desired Behavior

It should only be visible in the level 1 Options menu.

Copy link
Contributor

greptile-apps bot commented Jul 3, 2024

To remove the 'Compact view' toggle from L2 Kanban Option Menu, update the conditional rendering logic in RecordIndexOptionsDropdownContent.tsx:

  1. Locate the viewType === ViewType.Kanban block.
  2. Move this block to render only when !currentMenu is true.
{!currentMenu && viewType === ViewType.Kanban && (
  <>
    <DropdownMenuSeparator />
    <DropdownMenuItemsContainer>
      <MenuItemToggle
        LeftIcon={IconBaselineDensitySmall}
        onToggleChange={() =>
          setAndPersistIsCompactModeActive(
            !isCompactModeActive,
            currentViewWithCombinedFiltersAndSorts,
          )
        }
        toggled={isCompactModeActive}
        text="Compact view"
        toggleSize="small"
      />
    </DropdownMenuItemsContainer>
  </>
)}

References

/packages/twenty-front/src/modules/object-record/record-index/options/components/RecordIndexOptionsDropdownContent.tsx

About Greptile

This response provides a starting point for your research, not a precise solution.

Help us improve! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

Ask Greptile · Edit Issue Bot Settings

@saurabhsubham113
Copy link

Hi @Bonapara ,

I want to work on this.

@Bonapara
Copy link
Member Author

Bonapara commented Jul 5, 2024

Sure @saurabhsubham113, thanks for contributing!

@saurabhsubham113
Copy link

Hi @Bonapara

one small help required. do you have any documentation on how to setup this monorepo project in local and run the twenty-front project.

It would be really helpful

@Bonapara
Copy link
Member Author

Bonapara commented Jul 5, 2024

Hi @saurabhsubham113, we have docs.twenty.com. If you have further questions, feel free to ask on Discord!

@Faisal-imtiyaz123
Copy link
Contributor

@Bonapara I would like to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short
Projects
Archived in project
3 participants