Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Dark Mode, some DatePicker elements stay in light theme colors #5073

Closed
1 task done
orinamio opened this issue Apr 20, 2024 · 0 comments
Closed
1 task done

In Dark Mode, some DatePicker elements stay in light theme colors #5073

orinamio opened this issue Apr 20, 2024 · 0 comments

Comments

@orinamio
Copy link
Contributor

orinamio commented Apr 20, 2024 •
edited
Loading

Bug Description

In dark mode, some DatePicker elements remain black instead of updating to theme colors for dark mode.

theming bug

Expected behavior

The clock icon, date picker text and selected date colors should be white.

Technical inputs

These issues can be fixed with some CSS modifications.

I'll create a PR to fix them.

Tasks
Beta Give feedback
  1. #5073 - fix datepicker styling in dark mode #5074
@orinamio orinamio changed the title In Dark Mode, some DatePicker elements stay in light theme colors. In Dark Mode, some DatePicker elements stay in light theme colors Apr 20, 2024
orinamio added a commit to orinamio/twenty that referenced this issue Apr 20, 2024
@orinamio
twentyhq#5073 - fix datepicker styling in dark mode
ab25097
@orinamio orinamio mentioned this issue Apr 20, 2024
Merged
thomtrp pushed a commit that referenced this issue Apr 24, 2024
@orinamio
#5073 - fix datepicker styling in dark mode (#5074)
adbc8ab 
This PR fixes three issues with the datepicker in dark mode. The
following UI elements now appear in light colors when the theme is set
to dark mode:

- The selected date.
- The clock icon.
- The date time input component.

Before:
<img width="1003" alt="theming bug"
src="https://github.com/twentyhq/twenty/assets/16918891/914b7043-e692-4de8-8440-ddd89cbf3973">

After:
<img width="374" alt="dark_theme_calendar_after"
src="https://github.com/twentyhq/twenty/assets/16918891/346fd950-1ef8-405e-9486-59abb81f92db">
<img width="347" alt="light_theme_calendar_after"
src="https://github.com/twentyhq/twenty/assets/16918891/17463094-53e5-4bc4-8812-a53a37cd08ed">

#5073

Co-authored-by: Thomas Trompette <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Apr 25, 2024
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this issue Oct 6, 2024
@orinamio
twentyhq#5073 - fix datepicker styling in dark mode (twentyhq#5074)
bfb31ee 
This PR fixes three issues with the datepicker in dark mode. The
following UI elements now appear in light colors when the theme is set
to dark mode:

- The selected date.
- The clock icon.
- The date time input component.

Before:
<img width="1003" alt="theming bug"
src="https://github.com/twentyhq/twenty/assets/16918891/914b7043-e692-4de8-8440-ddd89cbf3973">

After:
<img width="374" alt="dark_theme_calendar_after"
src="https://github.com/twentyhq/twenty/assets/16918891/346fd950-1ef8-405e-9486-59abb81f92db">
<img width="347" alt="light_theme_calendar_after"
src="https://github.com/twentyhq/twenty/assets/16918891/17463094-53e5-4bc4-8812-a53a37cd08ed">

twentyhq#5073

Co-authored-by: Thomas Trompette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orinamio and others