Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remotes][Bug] Fix refresh issue after creating/deleting connection #5057

Closed
Tracked by #3920
thomtrp opened this issue Apr 19, 2024 · 0 comments · Fixed by #5684
Closed
Tracked by #3920

[Remotes][Bug] Fix refresh issue after creating/deleting connection #5057

thomtrp opened this issue Apr 19, 2024 · 0 comments · Fixed by #5684
Assignees
Labels
scope: front Issues that are affecting the frontend side only

Comments

@thomtrp
Copy link
Contributor

thomtrp commented Apr 19, 2024

What

When creating/deleting a connection, redirection is made but the connections list is not updated in production

@thomtrp thomtrp self-assigned this Apr 19, 2024
@thomtrp thomtrp converted this from a draft issue Apr 19, 2024
@thomtrp thomtrp added the scope: front Issues that are affecting the frontend side only label Apr 19, 2024
@thomtrp thomtrp moved this from 🆕 New to 🔖 Planned in Product development ✅ Apr 19, 2024
@thomtrp thomtrp assigned ijreilly and unassigned thomtrp Apr 19, 2024
@thomtrp thomtrp changed the title [Remotes] Fix refresh issue after creating/deleting connection [Remotes][Bug] Fix refresh issue after creating/deleting connection Apr 19, 2024
@ijreilly ijreilly moved this from 🔖 Planned to 🏗 In progress in Product development ✅ May 23, 2024
@charlesBochet charlesBochet moved this from 🏗 In progress to 🔖 Planned in Product development ✅ May 28, 2024
@ijreilly ijreilly moved this from 🔖 Planned to 🏗 In progress in Product development ✅ May 28, 2024
@ijreilly ijreilly moved this from 🏗 In progress to ✅ Done in Product development ✅ May 28, 2024
@ijreilly ijreilly moved this from ✅ Done to 🏗 In progress in Product development ✅ May 28, 2024
@ijreilly ijreilly moved this from 🏗 In progress to 👀 In review in Product development ✅ May 30, 2024
ijreilly added a commit that referenced this issue May 31, 2024
…f using refetchQuery (#5684)

Closes #5057.

RefetchQuery is unreliable - [it won't be executed if the component is
unmounted](apollographql/apollo-client#5419),
which is the case here because of the redirection that occurs after the
mutation.
We want to avoid using refetchQuery as much as possible, and write
directly in the cache instead.
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Product development ✅ May 31, 2024
Weiko pushed a commit that referenced this issue May 31, 2024
…f using refetchQuery (#5684)

Closes #5057.

RefetchQuery is unreliable - [it won't be executed if the component is
unmounted](apollographql/apollo-client#5419),
which is the case here because of the redirection that occurs after the
mutation.
We want to avoid using refetchQuery as much as possible, and write
directly in the cache instead.
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this issue Oct 6, 2024
…f using refetchQuery (twentyhq#5684)

Closes twentyhq#5057.

RefetchQuery is unreliable - [it won't be executed if the component is
unmounted](apollographql/apollo-client#5419),
which is the case here because of the redirection that occurs after the
mutation.
We want to avoid using refetchQuery as much as possible, and write
directly in the cache instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: front Issues that are affecting the frontend side only
Projects
Archived in project
2 participants