Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode in multi-select picker #4976

Closed
FelixMalfait opened this issue Apr 15, 2024 · 13 comments
Closed

Fix dark mode in multi-select picker #4976

FelixMalfait opened this issue Apr 15, 2024 · 13 comments
Labels
good first issue Good for newcomers

Comments

@FelixMalfait
Copy link
Member

Dark mode looks awful when you try to see the full list of selected items (type on "+15" if you have 17 items)

Screenshot 2024-04-15 at 18 27 02
@Bonapara
Copy link
Member

The background should be Transparent Secondary with the blurred backdrop-filter

@sakshi4321
Copy link

sakshi4321 commented Apr 17, 2024

Hi @FelixMalfait, @Bonapara can I work on this issue?

@Albert-2
Copy link

hey @FelixMalfait
i would very much like to contribute to this issue if no one is working on it
Thank You....!!

@FelixMalfait
Copy link
Member Author

@Albert-2 great feel free to raise a PR! Thanks

@Albert-2
Copy link

@FelixMalfait
you mean create new issue.....??

@FelixMalfait
Copy link
Member Author

@Albert-2 a pull request

@Albert-2
Copy link

ok @FelixMalfait I will
but can you please assign me the issue as well

@FelixMalfait FelixMalfait assigned Albert-2 and unassigned sakshi4321 Apr 19, 2024
@FelixMalfait
Copy link
Member Author

Sure, should be a one-line change so not too long that's why I assumed it was as fast to just raise a PR 😁 (and that @sakshi4321 I considered you probably moved away from the task)

Thanks!

@Albert-2
Copy link

Albert-2 commented Apr 20, 2024

hey @FelixMalfait
Sorry brother, i seriously tried my best
but the project is quite complex for me
hope you will consider
Thank You

@orinamio
Copy link
Contributor

orinamio commented Apr 20, 2024

Hi! I'll create a PR to fix this issue. @FelixMalfait can you assign me to it?

@orinamio
Copy link
Contributor

Has this issue been resolved? Unable to reproduce the bug. Otherwise, @FelixMalfait can you provide clearer instructions on how reproduce it?

Here's a video of my test:

issue.4976.mov

@Albert-2 Albert-2 removed their assignment Apr 20, 2024
@Bonapara
Copy link
Member

Hi @orinamio, to me, this issue concerns the expanded cell that appears when clicking the +X tag, which is displayed when there are more tags than the available width can accommodate.

Try to add more context to see the +X appear!

@orinamio
Copy link
Contributor

Found it and creating a PR to fix it. Thanks for the insight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants