Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Opacity and Apply backdrop-filter to all Transparent Colors #4836

Closed
Bonapara opened this issue Apr 5, 2024 · 2 comments
Closed

Update Opacity and Apply backdrop-filter to all Transparent Colors #4836

Bonapara opened this issue Apr 5, 2024 · 2 comments
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@Bonapara
Copy link
Member

Bonapara commented Apr 5, 2024

Current Behavior

We have 3 transparent colors in the theme. We should only have: Transparent/Primary and Transparent/Secondary.

Desired Behavior

The plan is to switch the opacity from 0.8 to 0.5 on Transparent/Primary and Transparent/Secondary.

This should allow us to remove forBackdropFilter: RGBA(GRAY_SCALE.gray10, 0.5) from the theme.

We need to ensure that backdrop-filter: blur(12px) saturate(200%) contrast(50%) brightness(130%); applies to all elements/components using transparent/primary or transparent/secondary. Specifically, this parameter needs to be updated on the 'Floating icon button' and All menus (That should have these properties = blur + transparent/secondary).

Floating icon button:

CleanShot 2024-04-05 at 11 06 10

Menus:

CleanShot 2024-04-05 at 11 06 41

Please verify if any other elements use Transparent/Primary and Transparent/Secondary to apply the background filter to them. Avoid referring to Figma, as the blur effect differs there.

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels Apr 5, 2024
@jss475
Copy link
Contributor

jss475 commented May 1, 2024

Hey @Bonapara. Can you assign this to me? :)

@Bonapara
Copy link
Member Author

Bonapara commented May 3, 2024

Sure @jss475 , thanks for contributing!

FelixMalfait added a commit that referenced this issue May 16, 2024
Update for #4836 

- edit primary and secondary transparency opacities from 0.8 to 0.5
- remove forBackdropFilter from themes
- update components referencing transparency/primary and
transparency/secondary to have the following backdrop-filter: blur(12px)
saturate(200%) contrast(50%) brightness(130%)

---------

Co-authored-by: Félix Malfait <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ May 17, 2024
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this issue Oct 6, 2024
)

Update for twentyhq#4836 

- edit primary and secondary transparency opacities from 0.8 to 0.5
- remove forBackdropFilter from themes
- update components referencing transparency/primary and
transparency/secondary to have the following backdrop-filter: blur(12px)
saturate(200%) contrast(50%) brightness(130%)

---------

Co-authored-by: Félix Malfait <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
Archived in project
Development

No branches or pull requests

3 participants