refactor: move callbacks in separate function declarations

twentyhq · Dec 3, 2024 · 943dca6 · 943dca6
1 parent aafb8b1
commit 943dca6
Showing 1 changed file with 25 additions and 17 deletions.
diff --git a/...ont/src/modules/object-record/record-field/form-types/components/FormSelectFieldInput.tsx b/...ont/src/modules/object-record/record-field/form-types/components/FormSelectFieldInput.tsx
@@ -159,6 +159,29 @@ export const FormSelectFieldInput = ({
     onPersist(variableName);
   };
 
+  const handleDisplayModeClick = () => {
+    if (draftValue.type !== 'static') {
+      throw new Error(
+        'This function can only be called when editing a static value.',
+      );
+    }
+
+    setDraftValue({
+      ...draftValue,
+      editingMode: 'edit',
+    });
+
+    setHotkeyScopeAndMemorizePreviousScope(hotkeyScope);
+  };
+
+  const handleSelectEnter = (itemId: string) => {
+    const option = filteredOptions.find((option) => option.value === itemId);
+    if (isDefined(option)) {
+      onSubmit(option.value);
+      resetSelectedItem();
+    }
+  };
+
   useScopedHotkeys(
     Key.Escape,
     () => {
@@ -187,14 +210,7 @@ export const FormSelectFieldInput = ({
             <>
               <StyledDisplayModeContainer
                 data-open={draftValue.editingMode === 'edit'}
-                onClick={() => {
-                  setDraftValue({
-                    ...draftValue,
-                    editingMode: 'edit',
-                  });
-
-                  setHotkeyScopeAndMemorizePreviousScope(hotkeyScope);
-                }}
+                onClick={handleDisplayModeClick}
               >
                 <VisibilityHidden>Edit</VisibilityHidden>
 
@@ -212,15 +228,7 @@ export const FormSelectFieldInput = ({
                   selectableListId={SINGLE_RECORD_SELECT_BASE_LIST}
                   selectableItemIdArray={optionIds}
                   hotkeyScope={hotkeyScope}
-                  onEnter={(itemId) => {
-                    const option = filteredOptions.find(
-                      (option) => option.value === itemId,
-                    );
-                    if (isDefined(option)) {
-                      onSubmit(option.value);
-                      resetSelectedItem();
-                    }
-                  }}
+                  onEnter={handleSelectEnter}
                 >
                   <SelectInput
                     parentRef={selectWrapperRef}