fix: tests

twentyhq · Mar 12, 2024 · 42c2cf9 · 42c2cf9
1 parent 2faceb3
commit 42c2cf9
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/...orkspace/workspace-sync-metadata/comparators/__tests__/workspace-field.comparator.spec.ts b/...orkspace/workspace-sync-metadata/comparators/__tests__/workspace-field.comparator.spec.ts
@@ -29,7 +29,12 @@ describe('WorkspaceFieldComparator', () => {
   it('should generate CREATE action for new fields', () => {
     const original = { fields: [] } as any;
     const standard = {
-      fields: [createMockFieldMetadata({ name: 'New Field' })],
+      fields: [
+        createMockFieldMetadata({
+          standardId: 'no-field-1',
+          name: 'New Field',
+        }),
+      ],
     } as any;
 
     const result = comparator.compare(original, standard);
@@ -46,6 +51,7 @@ describe('WorkspaceFieldComparator', () => {
     const original = {
       fields: [
         createMockFieldMetadata({
+          standardId: '1',
           id: '1',
           isNullable: true,
         }),
@@ -54,6 +60,7 @@ describe('WorkspaceFieldComparator', () => {
     const standard = {
       fields: [
         createMockFieldMetadata({
+          standardId: '1',
           isNullable: false,
         }),
       ],
@@ -73,6 +80,7 @@ describe('WorkspaceFieldComparator', () => {
     const original = {
       fields: [
         createMockFieldMetadata({
+          standardId: '1',
           id: '1',
           name: 'Removed Field',
           isActive: true,
@@ -93,10 +101,12 @@ describe('WorkspaceFieldComparator', () => {
 
   it('should not generate any action for identical fields', () => {
     const original = {
-      fields: [createMockFieldMetadata({ id: '1', isActive: true })],
+      fields: [
+        createMockFieldMetadata({ standardId: '1', id: '1', isActive: true }),
+      ],
     } as any;
     const standard = {
-      fields: [createMockFieldMetadata({})],
+      fields: [createMockFieldMetadata({ standardId: '1' })],
     } as any;
 
     const result = comparator.compare(original, standard);

diff --git a/...rkspace/workspace-sync-metadata/comparators/__tests__/workspace-object.comparator.spec.ts b/...rkspace/workspace-sync-metadata/comparators/__tests__/workspace-object.comparator.spec.ts
@@ -22,6 +22,7 @@ describe('WorkspaceObjectComparator', () => {
 
   it('should generate CREATE action for new objects', () => {
     const standardObjectMetadata = createMockObjectMetadata({
+      standardId: 'no-object-1',
       description: 'A standard object',
     });
 
@@ -35,10 +36,12 @@ describe('WorkspaceObjectComparator', () => {
 
   it('should generate UPDATE action for objects with differences', () => {
     const originalObjectMetadata = createMockObjectMetadata({
+      standardId: '1',
       id: '1',
       description: 'Original description',
     });
     const standardObjectMetadata = createMockObjectMetadata({
+      standardId: '1',
       description: 'Updated description',
     });
 
@@ -58,10 +61,12 @@ describe('WorkspaceObjectComparator', () => {
 
   it('should generate SKIP action for identical objects', () => {
     const originalObjectMetadata = createMockObjectMetadata({
+      standardId: '1',
       id: '1',
       description: 'Same description',
     });
     const standardObjectMetadata = createMockObjectMetadata({
+      standardId: '1',
       description: 'Same description',
     });
 

diff --git a/...ages/twenty-server/src/workspace/workspace-sync-metadata/utils/sync-metadata.util.spec.ts b/...ages/twenty-server/src/workspace/workspace-sync-metadata/utils/sync-metadata.util.spec.ts
@@ -7,13 +7,15 @@ describe('mapObjectMetadataByUniqueIdentifier', () => {
   it('should convert an array of ObjectMetadataEntity objects into a map', () => {
     const arr: DeepPartial<ObjectMetadataEntity>[] = [
       {
+        standardId: 'user',
         nameSingular: 'user',
         fields: [
           { name: 'id', type: FieldMetadataType.UUID },
           { name: 'name', type: FieldMetadataType.TEXT },
         ],
       },
       {
+        standardId: 'product',
         nameSingular: 'product',
         fields: [
           { name: 'id', type: FieldMetadataType.UUID },
@@ -29,13 +31,15 @@ describe('mapObjectMetadataByUniqueIdentifier', () => {
 
     expect(mappedObject).toEqual({
       user: {
+        standardId: 'user',
         nameSingular: 'user',
         fields: [
           { name: 'id', type: FieldMetadataType.UUID },
           { name: 'name', type: FieldMetadataType.TEXT },
         ],
       },
       product: {
+        standardId: 'product',
         nameSingular: 'product',
         fields: [
           { name: 'id', type: FieldMetadataType.UUID },