Add try_from_iter for *MemoryRegion and *RegisterData #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdoordt
force-pushed
the
fallible-memory-init
branch
from
75c1622 to
53fb533
Compare
|
Ah yeah, CI is broken. We can ignore macos and windows. |
hdoordt
force-pushed
the
fallible-memory-init
branch
from
de801df to
cefd41e
Compare
|
@diondokter please validate carefully if the new |
diondokter
requested changes
Aug 25, 2023
Comment on lines
136
to
139
| // Check that all register bytes will fit in `registers` | ||
| let num_register_bytes = register_count as usize * register_size; | ||
| if num_register_bytes > SIZE { | ||
| return Err(LengthTooBig(register_count, register_size)); | ||
| } |
There was a problem hiding this comment.
The tests fail. I think it's because SIZE here is the amount of registers and not the byte count of the registers
There was a problem hiding this comment.
@diondokter tests should be fixed now. Thanks for having a look!
hdoordt
force-pushed
the
fallible-memory-init
branch
from
cefd41e to
fd488dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #33