Initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baltpeter
force-pushed
the
b_initial-implementation
branch
from
008ca61
to
3fad5cb
Compare
baltpeter
force-pushed
the
b_initial-implementation
branch
from
4694b6e
to
c84f293
Compare
baltpeter
force-pushed
the
b_initial-implementation
branch
from
c84f293
to
1dd233a
Compare
baltpeter
force-pushed
the
b_initial-implementation
branch
from
1dd233a
to
61d3b6a
Compare
We need to do the same thing in platform.
While I'm not the biggest fan of duplicating the code, we were also (needlessly) inheriting the Node 18 restriction from CA. Also, CA is pretty huge and I never liked depending on that just for this one type. Since the type is expected to be pretty stable, I don't think vendoring it is too much of an issue.
|
Ugh, unfortunately, ReportHAR is currently not usable as a library. Trying to install it fails with: I guess I shouldn't be surprised that patch-package doesn't really work for libraries, but I hadn't considered that. Well, I guess we'll just have to create a nunjucks fork. Given how simple our patch is and how seldom nunjucks gets updated, that should be fine. |
I was getting the following error when trying to use ReportHAR as a library: Module "trackhar/i18n/en.json" needs an import assertion of type "json" But adding the assertion didn't help—Parcel strips those.
baltpeter
force-pushed
the
b_initial-implementation
branch
from
a181cfd
to
acddc3e
Compare
baltpeter
force-pushed
the
b_initial-implementation
branch
from
553c889
to
22ae2f8
Compare
baltpeter
force-pushed
the
b_initial-implementation
branch
from
26ff75d
to
acc5eaf
Compare
zner0L
reviewed
Jun 20, 2024
zner0L
approved these changes
Jun 21, 2024
baltpeter
added a commit
that referenced
this pull request
Jun 25, 2024
* Import har2pdf code * har2pdf: Shift all headings down by one * har2pdf: Make heading referencable * First somewhat working prototype * Description * Only print requests referenced in the report * Reference tracker-wiki in report * Escaping * Outsource style to external file * Controller notices * Complaints * delete unused translations file * Fixes #5: Render App Privacy Report/TrackerControl export * Refactor GenerateOptions * Mention app version in second analysis in complaint * Complaint: Only include requests from user's network activity report * Rename to ReportHAR * Factor out traffic preparation * Factor out Nunjucks code * Factor out Typst compilation * har2pdf: fix typo in encoding detection * extract meta from tweasel HARs * Allow passing harMd5 * Write docstrings * write readme * Fixes #4: Include software versions in report * Add link to HAR tutorial * Export prepareTraffic() We need to do the same thing in platform. * Vendor TweaselHar type While I'm not the biggest fan of duplicating the code, we were also (needlessly) inheriting the Node 18 restriction from CA. Also, CA is pretty huge and I never liked depending on that just for this one type. Since the type is expected to be pretty stable, I don't think vendoring it is too much of an issue. * Upgrade Parcel Due to: parcel-bundler/parcel#9419 * Switch to our custom nunjucks fork * Inline TrackHAR translations in bundle I was getting the following error when trying to use ReportHAR as a library: Module "trackhar/i18n/en.json" needs an import assertion of type "json" But adding the assertion didn't help—Parcel strips those. * Export translations * Support TrackerControl individual app exports * Switch to released TrackHAR * Template for informal complaints * Actually convince Parcel to inline the translations and templates Quite finicky… * Remove yalc and update TrackHAR * Add method section to report --------- Co-authored-by: Lorenz Sieben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be squashed.