Remove partial field accessors from AuthenticationError #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes a lot of sense to me. The only reason I can think of to have the field accessors is if they match up with property names from the specification. (And even then it is questionable to have them.) But as far as I can tell this is not the case here. I'd be happy to accept a patch with all the partial accessors removed! |
|
Thanks for the response @sjoerdvisscher! Closing this PR as it's subsumed by #193. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These field accessors for
AuthenticationErrorare partial functions that probably aren't necessary to keep around.Similar partial field accessors also appear in other types, e.g.
RegistrationError,UncheckedPublicKey.I'd be willing to go through the project and address all of them, but I first wanted to make sure that you guys would be open to the changes.