Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ClaimSet subtypes #188

Merged
merged 3 commits into from
May 17, 2024
Merged

Implement ClaimSet subtypes #188

merged 3 commits into from
May 17, 2024

Conversation

sjoerdvisscher
Copy link
Member

In the jose library, unregisteredClaims is deprecated. Here is a possible new implementation that follows the suggestion in the jose library to use subtypes.

If you think this is the right approach I'll continue with rewriting the tests.

Copy link
Contributor

@ErinvanderVeen ErinvanderVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me! I look forward to seeing the tests!

@sjoerdvisscher sjoerdvisscher marked this pull request as ready for review May 16, 2024 15:55
Copy link
Contributor

@ErinvanderVeen ErinvanderVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Style Check CI step incorrectly succeeds with the following output:

Run nix-shell --run "bin/autoformat.sh"
error:
       … while calling the 'import' builtin

         at «string»:1:2:

            1| (import <nixpkgs> {}).bashInteractive
             |  ^

       … while calling the 'findFile' builtin

         at «string»:1:9:

            1| (import <nixpkgs> {}).bashInteractive
             |         ^

       error: file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I)

       at «none»:0: (source not available)
will use bash from your environment
No hints

I think for now, just run bin/autoformat.sh manually. I'll create an issue that CI is broken.

@ErinvanderVeen ErinvanderVeen merged commit 3c68abf into master May 17, 2024
5 checks passed
@ErinvanderVeen ErinvanderVeen deleted the sv/jwt-subtype branch May 17, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants