Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing monotonicTime #187

Merged
merged 3 commits into from
May 14, 2024
Merged

Add missing monotonicTime #187

merged 3 commits into from
May 14, 2024

Conversation

sjoerdvisscher
Copy link
Member

@sjoerdvisscher sjoerdvisscher commented May 13, 2024 •
edited
Loading

I got a warning about this when compiling.

It is added to the MonadTime class in monad-time-0.4.0.0. (A small downside of not having upper bounds.)

ErinvanderVeen
ErinvanderVeen suggested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@ErinvanderVeen ErinvanderVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this change also require a bump in the lower bound of our monad-time dependency? Otherwise GHC might complain about the new function not being a member of the class.

@ErinvanderVeen ErinvanderVeen merged commit ca1a0af into master May 14, 2024
5 checks passed
@ErinvanderVeen ErinvanderVeen deleted the sv/monotonicTime branch May 14, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErinvanderVeen ErinvanderVeen ErinvanderVeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjoerdvisscher @ErinvanderVeen