Pass a list of allowed origins instead of a single origin #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android and iOS also support WebAuthn just like browsers. The apps will use their AppStore/PlayStore AppID as the origin. This means we need to allow a list of origins instead of a single origin. Apple uses https://developer.apple.com/documentation/xcode/supporting-associated-domains to link the app origin to the RpId Google uses an assetlinks.json file: https://developers.google.com/identity/fido/android/native-apps#interoperability_with_your_website
|
Multiple origins looks like a Webauthn 3 (which is still a draft) specific notion, see https://www.w3.org/TR/webauthn-3/#sctn-validating-origin, this doesn't seem to be documented in Webauthn 2. This library currently only implements Webauthn 2, but this seems very benign, and since it's already used in practice, it sounds fine to add. Please add some comments to the code/docs to explain this context. |
infinisil
requested changes
Mar 28, 2024
infinisil
requested changes
Mar 28, 2024
|
Would also be neat to have a test with two origins ;) |
Co-authored-by: Silvan Mosberger <[email protected]>
|
I added some quickcheck properties now. Hope this suffices? :D PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android and iOS also support WebAuthn just like browsers.
The apps will use their AppStore/PlayStore AppID as the origin. This means we need to allow a list of origins instead of a single origin.
Apple uses https://developer.apple.com/documentation/xcode/supporting-associated-domains to link the app origin to the RpId
Google uses an assetlinks.json file:
https://developers.google.com/identity/fido/android/native-apps#interoperability_with_your_website