Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymous classes defined with inline-java cannot refer to sparkle.jar #108

Closed
facundominguez opened this issue Apr 26, 2017 · 0 comments
Closed

Anonymous classes defined with inline-java cannot refer to sparkle.jar #108

facundominguez opened this issue Apr 26, 2017 · 0 comments

Comments

@facundominguez
Copy link
Member

facundominguez commented Apr 26, 2017 •
edited
Loading

The fix to #104 is not quite usable for sparkle users yet. When the classes that loadJavaWrappers loads depend on classes in the sparkle application jar, the class loader can't find them when loadJavaWrappers is invoked in InlineJavaRegistrator.java.

The former approach proposed there (tweag/inline-java#62) does not suffer of this problem.
mboes added a commit to tweag/inline-java that referenced this issue May 21, 2017
@mboes
Use the context class loader, not the system class loader.
f22e1f0 
These do not always correspond. The system class loader is immutable,
whereas the calling context might want to set their own class loader.
This is the case e.g. of Spark.

Fixes tweag/sparkle#108.
@mboes mboes mentioned this issue May 21, 2017
Merged
mboes added a commit to tweag/inline-java that referenced this issue Jun 21, 2017
@mboes
Use the context class loader, not the system class loader.
04450ac 
These do not always correspond. The system class loader is immutable,
whereas the calling context might want to set their own class loader.
This is the case e.g. of Spark.

Fixes tweag/sparkle#108.
mboes added a commit to tweag/inline-java that referenced this issue Jun 21, 2017
@mboes
Use the context class loader, not the system class loader.
9015736 
These do not always correspond. The system class loader is immutable,
whereas the calling context might want to set their own class loader.
This is the case e.g. of Spark.

Fixes tweag/sparkle#108.
mboes added a commit to tweag/inline-java that referenced this issue Jun 21, 2017
@mboes
Use the context class loader, not the system class loader.
aebd6c0 
These do not always correspond. The system class loader is immutable,
whereas the calling context might want to set their own class loader.
This is the case e.g. of Spark.

Fixes tweag/sparkle#108.
mboes added a commit to tweag/inline-java that referenced this issue Jun 21, 2017
@mboes
Use the context class loader, not the system class loader.
89a7819 
These do not always correspond. The system class loader is immutable,
whereas the calling context might want to set their own class loader.
This is the case e.g. of Spark.

Fixes tweag/sparkle#108.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@facundominguez