-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra_flags_per_feature to cc toolchain #575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@@ -298,6 +298,7 @@ pkgs.runCommand "bazel-${cc.orignalName or cc.name}-toolchain" | |||
if [[ -x ${cc}/bin/ld.gold ]]; then echo True; else echo False; fi | |||
) | |||
) | |||
EXTRA_FLAGS_PER_FEATURE=() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discovered while testing that Bazel expects a dict
here. Noted at #574 (comment).
tool_paths
is an example of a dict
whose value is set here, the problem is that is a bash associative array (it is represented as a dict as that is the only way it can be).
It may be necessary to handle the case where repr
returns []
in toolchains/cc/cc.bzl
to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #576
Closes #574