readme instructions for rules_nixpkgs_java with bzlmod
#498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prednaz
commented
Apr 10, 2024
Comment on lines
+82
to
+83
| bazel_dep(name = "rules_nixpkgs_core", version = "0.12.0") | ||
| bazel_dep(name = "rules_nixpkgs_java", version = "0.12.0") |
There was a problem hiding this comment.
i used a version here that does not exist yet because the instructions do not work with the current version as mentioned above.
prednaz
commented
Apr 10, 2024
Comment on lines
+84
to
+85
| bazel_dep(name = "rules_java", version = "7.3.1") | ||
| bazel_dep(name = "platforms", version = "0.0.9") |
There was a problem hiding this comment.
these will eventually not be necessary anymore according to https://github.com/tweag/rules_nixpkgs/blob/master/testing/java/MODULE.bazel#L17-L20 . but i cannot leave a TODO comment here.
prednaz
force-pushed
the
philipp/java_instructions
branch
from
f2a7387
to
1ac48b6
Compare
prednaz
force-pushed
the
philipp/java_instructions
branch
from
1ac48b6
to
9a596ef
Compare
benradf
approved these changes
Jun 3, 2024
prednaz
added
merge-queue
malt3
approved these changes
Jun 3, 2024
|
no worries, ben. we have not even released the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added instructions for
rules_nixpkgs_javawith bzlmod for bazel 6 and 7.these instructions assume that #477 is fixed and #497 is merged.