Design document for Bazel module extension#344
Merged
mergify[bot] merged 3 commits intomasterfrom Mar 14, 2023
Merged
Conversation
benradf
approved these changes
Mar 14, 2023
Contributor
benradf
left a comment
benradf
left a comment
There was a problem hiding this comment.
A very comprehensive design document. I especially like how it's presented. This is a nuanced and tricky subject so the bulleted structure of context followed by impact is quite helpful to understanding. Great work!
Comment on lines
+193
to
+194
| repositories will need to be exposed through an intermediary and imported | ||
| into the package and toolchain repositories through that intermediary. |
Contributor
There was a problem hiding this comment.
I'm not quite clear on what an intermediary is in this context. A known repository (or repositories) imported by the package and toolchain repositories that itself accesses the tags they require?
Contributor
Author
There was a problem hiding this comment.
Yes, exactly. The hub repository is such an intermediary. I've added a sentence to point that out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a design document for rules_nixpkgs module extensions (#183).
The implementation will be added in a separate PR. You can see a sketch of the implementation here.